Apply drupal 8 coding standards

Created on 13 January 2020, almost 5 years ago
Updated 21 March 2023, over 1 year ago

The 8.x-1.x-dev branch doesn't follow the drupal 8 coding standards.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States Steven Spasbo Oakland, CA

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India arunkumark Coimbatore

    Found there are still major Drupal standard issues with the 8.x-1.x version. The major issues are listed below.

    FILE: /var/www/html/web/modules/custom/jw_player/src/Jw_playerListBuilder.php
    -----------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    -----------------------------------------------------------------------------
     11 | ERROR   | Class name must use UpperCamel naming without underscores
     33 | WARNING | Only string literals should be passed to t() where possible
    -----------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/modules/custom/jw_player/src/Entity/Jw_player.php
    -------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------
     45 | ERROR | Class name must use UpperCamel naming without underscores
    -------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/modules/custom/jw_player/src/Plugin/Field/FieldFormatter/JwplayerFormatter.php
    -------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
    -------------------------------------------------------------------------------------------------------
      78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
      80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     161 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     166 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
     198 | WARNING | Unused variable $preview_items.
     199 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead
    -------------------------------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/modules/custom/jw_player/src/Element/JwPlayer.php
    ---------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------
     19 | ERROR | Long array syntax must not be used in doc comment code annotations
    ---------------------------------------------------------------------------------
    
    
    FILE: /var/www/html/web/modules/custom/jw_player/src/Jw_playerInterface.php
    ----------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------
     10 | ERROR | Interface name must use UpperCamel naming without underscores
    ----------------------------------------------------------------------------
    
  • Status changed to Needs work almost 2 years ago
  • Assigned to Adil_Siddiqui
  • Issue was unassigned.
  • First commit to issue fork.
  • @kkalashnikov opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India kkalashnikov Ghaziabad, India
Production build 0.71.5 2024