- 🇮🇳India arunkumark Coimbatore
Found there are still major Drupal standard issues with the 8.x-1.x version. The major issues are listed below.
FILE: /var/www/html/web/modules/custom/jw_player/src/Jw_playerListBuilder.php ----------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------- 11 | ERROR | Class name must use UpperCamel naming without underscores 33 | WARNING | Only string literals should be passed to t() where possible ----------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/jw_player/src/Entity/Jw_player.php ------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------- 45 | ERROR | Class name must use UpperCamel naming without underscores ------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/jw_player/src/Plugin/Field/FieldFormatter/JwplayerFormatter.php ------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------- 78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 161 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 166 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead 198 | WARNING | Unused variable $preview_items. 199 | WARNING | ImageStyle::load calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/jw_player/src/Element/JwPlayer.php --------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------- 19 | ERROR | Long array syntax must not be used in doc comment code annotations --------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/jw_player/src/Jw_playerInterface.php ---------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------- 10 | ERROR | Interface name must use UpperCamel naming without underscores ----------------------------------------------------------------------------
- Status changed to Needs work
over 1 year ago 9:42am 24 February 2023 - Assigned to Adil_Siddiqui
- Issue was unassigned.
- First commit to issue fork.
- @kkalashnikov opened merge request.
- Status changed to Needs review
over 1 year ago 8:41am 21 March 2023