- Status changed to Needs work
over 2 years ago 1:44pm 21 January 2023 - 🇳🇱Netherlands johnv
#20 shows the relevance of 🐛 Make usability better for "Link display" setting Closed: outdated
- Merge request !11152"More link" does not take display arguments into account → (Open) created by mohit_aghera
- 🇮🇳India mohit_aghera Rajkot
Hi @xjm
I've fixed the following issues from comment #19- Point 1
- Point 2
Comment is updated for both the cases.
Regarding point 3:
- I've added the new test that validates both the points.
Fixed few more things in the MRAbout the
custom_url
option:
- Primarily it is visible on the block plugin display and other non-page display.
So I believe we should hide it from the page display?Probably we can use the inputs from the sub-system maintainer.
This might cause confusion to people as `More` link on the page display might not make sense.I notice that there is no option to configure the link, it just allows to enable/disable link.
Which is correct if we want to keep option.I'm happy to walk you through the views setup, feel free to ping me in #bugsmash.
Regarding #20
I agree with you for this one.
We can disable it from the page display and keep it active for block display.Hiding the patches since we have a MR now.
Keeping issue in needs works since there are a few unrelated test failures that I'm looking into it.