"More link" does not take display arguments into account

Created on 10 January 2020, over 5 years ago
Updated 15 January 2023, over 2 years ago

Steps to reproduce:

  1. Create a view with a page and a block
  2. Add exposed filter(s) to both
  3. Configure "more link" to point to the page display (not a custom URL)

Expected behavior:
Value from the block's exposed filter should be passed as an argument to the page.

E.g. for /search page path the link should contain /search?search=[search_query] in its path.

Instead, the link contains /search part only, either for cached and not cached views.

🐛 Bug report
Status

RTBC

Version

10.1

Component
Views 

Last updated about 19 hours ago

Created by

🇺🇦Ukraine d.novikov

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work over 2 years ago
  • 🇳🇱Netherlands johnv

    #20 shows the relevance of 🐛 Make usability better for "Link display" setting Closed: outdated

  • Pipeline finished with Failed
    3 months ago
    Total: 379s
    #418685
  • 🇮🇳India mohit_aghera Rajkot

    Hi @xjm
    I've fixed the following issues from comment #19

    • Point 1
    • Point 2

    Comment is updated for both the cases.

    Regarding point 3:
    - I've added the new test that validates both the points.
    Fixed few more things in the MR

    About the custom_url option:
    - Primarily it is visible on the block plugin display and other non-page display.
    So I believe we should hide it from the page display?

    Probably we can use the inputs from the sub-system maintainer.
    This might cause confusion to people as `More` link on the page display might not make sense.

    I notice that there is no option to configure the link, it just allows to enable/disable link.
    Which is correct if we want to keep option.

    I'm happy to walk you through the views setup, feel free to ping me in #bugsmash.

    Regarding #20
    I agree with you for this one.
    We can disable it from the page display and keep it active for block display.

    Hiding the patches since we have a MR now.
    Keeping issue in needs works since there are a few unrelated test failures that I'm looking into it.

Production build 0.71.5 2024