ConfigInstaller::isSyncing() is not reset before module preinstall

Rebased to run test-only feature

1) Drupal\KernelTests\Core\Config\ConfigImporterTest::testIsSyncingInHooks
\Drupal::isConfigSyncing() returns TRUE
Failed asserting that null is true.
/builds/issue/drupal-3103962/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-3103962/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3103962/core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php:848
/builds/issue/drupal-3103962/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!
Tests: 23, Assertions: 136, Failures: 1.

Hiding files for clarity.

Issue summary seems clear about what is being fixed and matches the solution in the MR.

LGTM!

Issue credits

Left some questions on the MR, tl;dr I think hook_module_preuninstall has the same issue and wonder if perhaps we should be doing the fix inside ::updateKernel so it resolves both issues at once.

@larowlan excellent point about uninstall. Install and uninstall should be mirrors.

I'm slightly dubious about the use-case here because what are you doing in pre-install - really shouldn't be doing anything permanent - so whatever is happening probably should happen regardless of whether we are syncing - but hey workspaces does interesting stuff here but it is inconsistent so +1 to fixing.

I think we should also consider adding is_syncing to the hook signature to anyone who implements hook_module_preinstall() has to consider the config syncing case.

I agree use cases are pretty obscure, and I'm having trouble recalling exactly how it was I ran into it four years ago. I believe that I was working on a project that had an install profile that used Config Rewrite ( https://www.drupal.org/project/config_rewrite → ). That module has an hook_module_preinstall() implementation that I wanted to prevent from happening when installing from existing configuration. Though it looks like between then and now they found a different way to do that detection.

Addressed review comment to restore state of config installer in ::updateKernel.
Added $is_syncing value as second parameter to hook_module_preinstall() and hook_module_preuninstall implementations.
Updated tests and rebased.
Added CR and updated IS.

@godotislate - nice work - one tiny nit in a kinda out-of-scope change and this will be rtbc.

Applied suggested change and moved to RTBC per last comment.

Committed ba827d4 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.