Test available updates when the current major and next major of core are supported

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This is just updating the MR to 11.x. There is no option to create a new branch on this issue.

Looking at the MR I saw that three lines of assertUpdateTableElementContains were removed. One is no longer needed because it was testing the 'download' link. One other switched to assertVersionUpdateLinks which is fine. But that loses the testing that the link is in the update table. The other line is for the release notes link. I have restored those last two assertUpdateTableElementContains lines.

I renamed the new xml files from '9-plus-8' to 'current'. I found '9-plus-8' accurate but hard to read and 'current' is what is used for getting the current release history. I also removed the alpha and beta releases from the xml files and a duplicated release. And added some comments to the test.

Was skimming the patch and found this that needs to be fixed.

+++ b/core/modules/update/tests/src/Functional/UpdateSemverTestBase.php
@@ -148,23 +148,48 @@ public function testNormalUpdateAvailable() {
+   * semver_test.current.xml have two major release supported, 8 and 9.

s/release/releases/

Trying to improve the comment block.

Reran the tests from #18 and seemed there were just some random failures. Tests are all green now.

Based on the IS I do believe #18 is addressing the task at hand (with cleaned up comments).

Think this is probably good.

This is definitely not good. I reviewed and see a grammar mistake in the first sentence. Uploading a fix.

Ah test change does read better.

The last submitted patch, 20: 3099825-20.patch, failed testing. View results →

Needed update after 📌 Split up update semver tests Fixed

Update seems good

#24 has numerous fails and the MR doesn't apply.

Hide patches.

All cleaned up now and tests are passing. One thing I am not sure about is the name 'current' used in semver_test.current.xml and
drupal.current.xml.

What's the concern with current if I may ask?

What about instead of calling the files current we use drupal.supported or drupal.previous.

Think that more falls inline with the content of the files. Current I would expect to 10.2, 10.3, (maybe something 11.x)

Least to me rest appears fine, so may be good to self RTBC after the change. @quietone.

Maybe, but these are test fixtures and they are all based on Drupal 8. Anyway, I have since worked on 📌 Remove legacy attributes, add supported_branches and consistently name update.module's XML fixtures Needs review and changed the names with my understanding from that issue.

Like that even better. Couldn't be clearer what the files are now.

Good timing to get this one done!

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.