- Status changed to RTBC
over 1 year ago 6:37am 16 January 2023 - Status changed to Needs work
over 1 year ago 6:46am 16 January 2023
Most of the test classes under core/modules/file/tests/src/Functional are derived from either FileFieldTestBase
or FileManagedTestBase
. Both of those define their own static $modules
array.
However, when we did
#3082655: Specify the $defaultTheme property in all functional tests β
we didn't notice this fact, and put separate $defaultTheme
definitions in all the children.
3 of them apparently depended on classy markup, so those set defaultTheme to classy. Everything else uses stark.
In addition to being duplicate code in most cases, these hunks can cause otherwise backportable test changes / additions to require separate patches for different branches, which is a minor hassle and creates more work for ourselves.
protected $defaultTheme = 'stark';
in the parent test classes.$defaultTheme
themselves.-
None. Tests aren't API.
-
-
Needs work
9.5
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.