The revision user is incorrect after CRON ran.

Re-rolling the patch #7 🐛 The revision user is incorrect after CRON ran. Needs work to work for branch 2.3.x.

#8 works for me

The last submitted patch, 7: revision_author-3094322-7.patch, failed testing. View results →

The latest MR patch has been working for us for some time now.

This should be rebased onto 2.8.x.

I didn't see @mohit_aghera added tests, thanks.

Thanks for that suggestion @mstrelan, looks good.

Just a minor nit I've added, otherwise this looks good.

Merged!

Thanks all.

As found in v2.8.2

Any chance of a backport to 2.7?

FYI this broke kernel tests for us on a module automating scheduled transitions in 2 ways:
1. User entity schema needed to be installed, it probably should have been anyway (ST also doesn't declare a dependency on the user module which should probably be fixed?)
2. $scheduledTransition->getAuthor() can return NULL if there's no current user setup, which in turn throws TypeError: Drupal\Core\Entity\RevisionableContentEntityBase::setRevisionUser(): Argument #1 ($account) must be of type Drupal\user\UserInterface, null given

Happy for a follow up, automated ST is a edge case and I can see why tests might not have caught it.

But I would have thought PHPStan would have caught it...

On entity schema, not much we can do about that. Adding a dep wont automatically install schema, etc. Its one of those things you have to deal with on your own if youre implementing kernel tests involving third party Drupal code.

But I would have thought PHPStan would have caught it...

PHPStan doesnt report on the issue to level 8. We are presently on level 9 + baselined strict.

167 Parameter #1 $account of method Drupal\Core\Entity\RevisionLogInterface::setRevisionUser()
expects Drupal\user\UserInterface, Drupal\user\UserInterface|null given.
🪪 argument.type