EntityUpdateAddRevisionTranslationAffectedTest::testDeleteEntityType() breaks loading of field configuration in post-update hook implementation,
#3052467-23: System update 8702 fails with " Error: Call to a member function getKey() on null in core\modules\system\system.install" →
. Any entity CRUD operations should be safe in post-update hook, but when we iterate over config entities (see patch for
🐛
Cannot load entity by uuid after rename
Needs work
) and try loading them by UUID through EntityRepositoryInterface::loadEntityByUuid(), that triggers loading field definitions and results in PluginNotFoundException 'The entity_test_update entity type does not exist.' being thrown.
The very same test fails now in #2928906-35: The field schema incorrectly stores serial fields as int → .
\Drupal\Tests\workspaces\Functional\Update\WorkspacesUpdateTest::testWorkspaceAssociationRemoval() and EntityUpdateAddRevisionTranslationAffectedTest::testDeleteEntityType() also failed in
#2928906-35: The field schema incorrectly stores serial fields as int →
.
The solution was to rewrite the update to:
function system_update_8901() {
$definition_update_manager = \Drupal::entityDefinitionUpdateManager();
$entity_type_manager = \Drupal::entityTypeManager();
foreach ($definition_update_manager->getEntityTypes() as $entity_type_id => $entity_type) {
// Ensure that we are dealing with a non-deleted entity type.
if (!$entity_type || !($entity_type instanceof ContentEntityTypeInterface) || !$entity_type_manager->hasDefinition($entity_type_id)) {
continue;
}
which ensures that we will not touch deleted entity types during the update. However this is not a solution for an update doing something similar to
#3052467-23: System update 8702 fails with " Error: Call to a member function getKey() on null in core\modules\system\system.install" →
, where the entity type is retrieved indirectly by loading a field config through EntityRepositoryInterface::loadEntityByUuid() which triggers
\Drupal\field\FieldConfigStorage::loadByProperties() ->
\Drupal\field\Entity\FieldConfig::getFieldStorageDefinition() ->
\Drupal\Core\Entity\EntityFieldManager::getFieldStorageDefinitions() ->
\Drupal\Core\Entity\EntityFieldManager::getBaseFieldDefinitions() ->
\Drupal\Core\Entity\EntityFieldManager::buildBaseFieldDefinitions() ->
\Drupal\Core\Entity\EntityTypeManager::getDefinition()
So here we have 2 problems.
EntityRepositoryInterface::loadEntityByUuid().The failing patch demonstrates both problems.
Maybe for the first problem we should prevent \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getEntityTypes() from returning entity types with deleted definitions and make this possible only through a parameter.
How to solve the second problem?
Postponed: needs info
11.0 🔥
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue was triaged as part of BSI.
The IS mentions some extremely old update hooks, is this bug still relevant in 11.x? Perhaps this needs a rewrite to tackle the other problems mentioned there?
Marking as PMNMI to get that info.