- 🇮🇹Italy apaderno Brescia, 🇮🇹
+ * @param string $bundle_id + * The bundle id.
id is misspelled.
+ * @param string $bundle_label + * The name of the bundle.
It is sufficient to say The bundle label.
- /** @var EntityStagingProcessFieldDefinitionEvent $event */ + /* @var \Drupal\entity_staging\Event\EntityStagingProcessFieldDefinitionEvent $event */
The existing comment is correct.
+ * @param string $entity_type * The entity type machine name.
There is no need to say machine name.
* @return \Drupal\Core\Entity\ContentEntityTypeInterface + * The entity type.
It actually return an entity, not an entity type.
* @return array + * Migration Dependencies. */
Dependencies is misspelled, since it is not at the beginning of the sentence.
* @param \Drupal\entity_staging\Event\EntityStagingBeforeExportEvent $event + * Field Definition Event.
It is missing an article.
There are misspelled words, since they are not at the beginning of the sentence. (Only the first word is at the beginning of the sentence.)- '#title' => t('Entity staging directory'), - '#description' => t('Directory where the content will be exported. This directory is relative to the drupal root.'), - '#default_value' => ($staging_directory) ? $staging_directory : '../staging' + '#title' => $this->t('Entity staging directory'), + '#description' => $this->t('Directory where the content will be exported. This directory is relative to the drupal root.'), + '#default_value' => ($staging_directory) ? $staging_directory : '../staging',
The code should use the null coalescing operator.
/** - * Get staging directory + * Get staging directory. * * @var string */ - protected $staging_directory;
The short descriptions for properties do not start with Get.
if (in_array($key, [ - 'type', - 'shortcut_set', - 'vid', - 'bundle', - 'queue', - ]) && isset($item['target_id'])) { + 'type', + 'shortcut_set', + 'vid', + 'bundle', + 'queue', + ]) && isset($item['target_id'])) { $value = $item['target_id']; }
The Drupal coding standards says that control structures are written on a single line.
- Status changed to Needs review
about 1 year ago 1:55pm 25 September 2023 - 🇫🇷France goz
-
+++ b/src/EventSubscriber/EntityStagingProcessEntityReferenceFieldSubscriber.php @@ -55,27 +55,27 @@ class EntityStagingProcessEntityReferenceFieldSubscriber implements EventSubscri - $dependencies[] = $migration; ... - // Spacial case for entity types with bundle but without bundles in field settings
This should not be changed, there is nothing to do with phpcs reports
-
+++ b/src/Plugin/migrate/source/EntityStagingJson.php @@ -20,23 +20,23 @@ class EntityStagingJson extends SourcePluginBase { + protected $inputPath;
Variable should not be renamed, there is no rules on that on phpcs
-
+++ b/src/Plugin/migrate/source/EntityStagingJson.php @@ -20,23 +20,23 @@ class EntityStagingJson extends SourcePluginBase { + protected $stagingDirectory;
Variable should not be renamed, there is no rules on that on phpcs
-
- Assigned to goz
- 🇫🇷France goz
+++ b/src/Plugin/migrate/source/EntityStagingJson.php
@@ -20,23 +20,23 @@ class EntityStagingJson extends SourcePluginBase {
+ protected $inputPath;Variable should not be renamed, there is no rules on that on phpcs
+++ b/src/Plugin/migrate/source/EntityStagingJson.php
@@ -20,23 +20,23 @@ class EntityStagingJson extends SourcePluginBase {
+ protected $stagingDirectory;My bad, there is lowerCamel rule
- @goz opened merge request.
- Status changed to Fixed
about 1 year ago 11:19am 20 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.