- Merge request !12458Enable host entity's translation support in fetching private files → (Open) created by mohit_aghera
- 🇺🇸United States smustgrave
Left some comments on the MR but think adding return types to the content_translation module seem out of scope of the issue at hand.
- 🇮🇳India mohit_aghera Rajkot
True that.
However, if I don't add those, phpstan is failing for our test case class.
Job https://git.drupalcode.org/issue/drupal-3090998/-/jobs/5656011 has more information. - 🇺🇸United States smustgrave
Thanks @oily but I reverted that change as it was out of scope and not related to this ticket.
I couldn't get the test-only job to run, was throwing some errors so I ran it locally
Behat\Mink\Exception\ExpectationException: Current response status code is 403, but 200 expected. /var/www/html/vendor/behat/mink/src/WebAssert.php:888 /var/www/html/vendor/behat/mink/src/WebAssert.php:145 /var/www/html/core/modules/file/tests/src/Functional/PrivateFileOnTranslatedEntityTest.php:193
Switching to check the translation makes sense.
- 🇬🇧United Kingdom oily Greater London
@smustgrave Thanks for reverting I agree with it (in hindsight)- seemed a good idea at the time : ).
- 🇩🇪Germany Anybody Porta Westfalica
🐛 Access denied to published private file if original translation is unpublished Needs review has been closed in favor of this - should be checked, if it's really duplicates.