- First commit to issue fork.
- Merge request !10908Issue #3085475: ItemCacheTagsTest and ShortcutCacheTagsTest needlessly test the render cache. β (Open) created by vidorado
- πΊπΈUnited States smustgrave
ItemCacheTagsTest was removed with aggregator so title doesn't need it
Left a comment on MR.
- πΊπΈUnited States smustgrave
Think my one comment still stands but will leave in review for others. Certainly not a hill Iβll die on lol
- πͺπΈSpain vidorado Pamplona (Navarra)
Haha, Iβm with you on being efficient and avoiding unnecessary duplication of resources.
We could refactor EntityCacheTagsTestBase so that the cache bins are stored in a class member variable within the setUp() method, which is a common practice. However, I always try to be cautious about not straying too far from the original scope.
You have a lot of experience, so Iβm always a bit worried about overlooking something.
Letβs see if others can share their thoughts, and weβll decide from there. :)
Thanks so much for all the effort you put into reviewing so many (often complex) issue queues!