ItemCacheTagsTest and ShortcutCacheTagsTest needlessly test the render cache.

Created on 3 October 2019, over 5 years ago
Updated 13 January 2025, 22 days ago

ItemCacheTagsTest::testEntityCreation() and ShortcutCacheTagsTest::testEntityCreation() check for cache entries in the render cache even though nothing was cached. This needlessly complicates things as any refactoring of the render cache might inadvertently make these tests fail as shown in #2551419-158: Abstract RenderCache into a separate service that is capable of cache redirects in a non-render array-specific way β†’

The easy fix is to add a new method to the base class that allows you to run a slimmed down version of verifyRenderCache that only runs the basic checks, does not check for redirects and, most importantly, uses the default cache backend.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component

system.module

Created by

πŸ‡§πŸ‡ͺBelgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024