Support loading ACE editor locally w/o CDN

Hmm I think it goes beyond just replacing the library path to load from a local version instead of the CDN, because the this module's asset_injector.ace_editor.js currently includes the following hardcoded:

          ace.config.set('basePath', '//cdnjs.cloudflare.com/ajax/libs/ace/1.8.1');
          ace.config.set('modePath', '//cdnjs.cloudflare.com/ajax/libs/ace/1.8.1');
          ace.config.set('themePath', '//cdnjs.cloudflare.com/ajax/libs/ace/1.8.1');

I think these three lines are only necessary if you're loading it from the CDN. This can probably be solved if we pass down via drupalSettings if the module used the CDN or not to load the main library, and if not, don't run these lines.

Okay, I was wrong, we need those lines regardless, because without them the library tries to auto-detect the path to those directories and it doesn't work if JS aggregation is turned on.

So, if the ace-builds version of the library is used (and stored locally), we need to provide its path via drupalSettings

I updated the MR for the latest changes.

Thanks @tobiasb - the README says

is taken from CDN as long as no min.js file exists

but I can't see related code, what am I missing?

Also see #18 - looks like hook_library_info_alter() and other parts like the tests are still missing?
The referenced issue is a nice template.

Therefore it was "needs work". :d

Wasn't :P

See #25 + #26

Status: Needs review » Needs work

Eventually by accident ;) All good