Focus any element on ajax calls

Open on Drupal.org →

Created on 12 September 2019, over 5 years ago

Updated 28 April 2023, over 1 year ago

Problem/Motivation

Targeting the parent of the removed DOM element on ajax sets focus, which is implicitly applicable to a limited set of elements, such as form elements (input, select, etc.) and links (a), based on https://api.jquery.com/focus.

Noticed that while working on the Entity browser issue linked here.

Steps to reproduce

Use an entity browser and edit an image.
After clicking "Save" in the modal, the "Save" button on the node gets focused - fixable by setting 'disable-refocus' => TRUE on the submit button in the Entity browser
With that fix above, no focus is set at all

Proposed resolution

We can use all element types by using tabindex.

🐛 Bug report

Status

Closed: duplicate

Version

10.1 ✨

Component

Last updated about 1 hour ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇸🇮Slovenia sasanikolic

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Accessibility
It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Closed: duplicate over 1 year ago11:20am 28 April 2023
Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Is this even still relevant?

AFAICT it's not possible to automatically determine which element to focus after an AJAX command — it's context-dependent.

#3188938: Create AjaxCommand for focusing that does not require :tabbable selector → added an AJAX command to make it feasible to do focus handling correctly, allowing each UI to handle it correctly in their context. Closing as a duplicate of that.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024