Contrib.social

All relationships are now Bidirectional

Open on Drupal.org →
Created on 9 August 2019, over 5 years ago
Updated 23 May 2023, almost 2 years ago

Problem/Motivation

In the D7 versions of the module, Corresponding Entity Relationships could be either uni- or bi-directional, allowing for the relationship to be maintained only when changed on one side of the relationship. This functionality is missing in the d8 version, and all relationships are bidirectional, which can cause issues in certain use cases. Given that this was functionality in the previous versions of the module, it probably should exist in the d8 version as well, even though it is not noted in #2951880: 5.0.0 Roadmap → .

Proposed resolution

Implement logic to allow for uni-directional CER to be processed, adapting isValid() to identify these situations and process (or not) depending on the configuration.

Remaining tasks

Implement it.

User interface changes

Needs the ability to specify bidirectionality for the config entity and display that setting on the list page.

API changes

Add the appropriate getter and setters to determine directionality of the entity. Add methods to determine if the relationship should be processed based on that setting.

Data model changes

The bidirectional property of the config entity.

✨ Feature request
Status

Needs work

Version

5.0

Component

Code

Created by

🇺🇸United States logickal

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment almost 2 years ago →
    🇨🇦Canada chrisck BC, Canada

    Changing the issue title to better reflect the work being done

  • Comment over 1 year ago →
    🇫🇷France tostinni

    Here is the patch updated for 5.0.0-beta3 and the reroll diff (only some very light changes in the patch due to #3075276: Adding option to prepend referenced entities if desired → creating some offset).

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    2 pass
  • Comment over 1 year ago →
    🇫🇷France tostinni

    Switching to needs review.

  • Comment about 1 year ago →
    🇺🇸United States mortona2k Seattle

    After applying the patch, one of my CERs wasn't working because it is now treated as uni directional. Setting it to bi directional fixed it (and the complete sync patch was helpful too!).

    I think we should assume bi-directional by default, or do an update hook to set existing config values.

  • Status changed to Needs work 10 months ago
  • Comment 10 months ago →
    🇺🇸United States mortona2k Seattle

    This patch has been working for me for a few months. I think we just need an update hook that sets the value to true in existing config.

    Was there another way to have uni directional relationships before this?

  • Merge request !19Apply patch #16 → (Open) created by mortona2k
  • Pipeline finished with Success
    3 months ago
    Total: 182s
    #404300
  • Comment 3 days ago →
    🇺🇸United States erutan

    While this isn't really worthy of a major version, in theory this could get bumped to 5.1 with a warning in the release notes to toggle bi-directional back on for all existing CERs. Not elegant or ideal.

    I've been using this on 10.4.6 and it's critical for a use case moving forward.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024