Add lookup dependency to url_alias migrations

Created on 1 August 2019, over 5 years ago
Updated 17 March 2024, 10 months ago

Problem/Motivation

Postponing on #3004927: Create Migration Lookup and Stub services β†’ as that issue should provide clarity on how we handle looking up against a non-existent migration.

The d6 and d7 url alias migrations do a migration_lookup on node translations but are not dependent on those migrations.

Steps to reproduce

Proposed resolution

Add optional dependencies to d6_ and d7_url_alias migration for d*_node_translation.
Also do not create stubs

Remaining tasks

See tags
MR
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
MigrationΒ  β†’

Last updated about 12 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States mikelutz Michigan, USA

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia acbramley

    This was triaged as part of BSI.

    It's not clear to me from the title or IS exactly what migrations this is referring to, but I assume it's these ones https://git.drupalcode.org/project/drupal/-/tree/11.x/core/modules/path/...

    Neither of those migrations declare any dependencies up front, but they could indeed come from somewhere else.

    Setting to PMNMI as we need an IS update and a clearer indication of what needs to happen here.

  • Status changed to Active 10 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • Merge request !7059fix: modify migrations β†’ (Open) created by mikelutz
  • Status changed to Needs work 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mikelutz Michigan, USA

    I don't recall making this issue, and there have been some changes with the addition of the node_complete migration system that may make this trickier, but I'm curious what breaks If we just do what 5-years-ago-me said we should do.

  • Pipeline finished with Success
    10 months ago
    Total: 567s
    #120128
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Thanks @mikelutz! That came back green. Not sure how I was reading the old title backwards (read as should not declare dependencies), this makes much more sense!

Production build 0.71.5 2024