Cache base table value in views_query

Created on 30 July 2019, over 5 years ago
Updated 30 January 2023, almost 2 years ago

In the views_query @ViewsQuery plugin (/core/modules/views/src/Plugin/views/query/Sql.php) the command $this->view->storage->get('base_table') that fetches the query's base table is called 21 times.
I suggest that we cache it in a property and set it once in the plugin initialisation.

Feature request
Status

Needs work

Version

10.1

Component
Views 

Last updated about 4 hours ago

Created by

🇳🇴Norway efpapado

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

  • needs profiling

    It may affect performance, and thus requires in-depth technical reviews and profiling.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build 0.71.5 2024