Error: Call to a member function getConfigDependencyKey() on null in web/core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php

1. +++ b/core/modules/taxonomy/tests/src/Functional/Views/MissingTaxonomyInstallation.php
   @@ -0,0 +1,55 @@
   +
   +  /**
   +   * Test that the view is installed with a missing vocabulary.
   +   *
   

   The comment doesn't seem to match the test. Also not sure the @throws is correct here, it's not an API that's just what happens when the test fails.

2. +++ b/core/modules/taxonomy/tests/src/Functional/Views/TaxonomyVocabularyArgumentTest.php
   @@ -78,4 +78,20 @@ public function testTermWithVocabularyArgument() {
    
   +  /**
   +   * Test that the view is deleted when the taxonomy term is.
   +   */
   

   Nit - it's a vocabulary being deleted, not a term.

   Also this isn't asserting that the view was deleted.

Also not clear to me if both tests are needed or only one, appear to be doing the same thing?

You are correct @catch they are doing the same. 1 could be deleted.

Removed 1 test.

Super trivial nit, otherwise this looks great. Fixing and RTBC'ing. Hope I'm not struck by lightning for this. 😂

This still doesn't look right to me - shouldn't the vocabulary be in the view dependencies and if so shouldn't that either prevent the vocabulary being deleted (or delete the view, although I don't think it should)? As it is we're letting the view get into an invalid state and suppressing the error.

I'm running into this error when running the views_post_update_remove_default_argument_skip_url db update during a 9.5.11-to-10.2.2 upgrade. While the null check may indeed be masking a problem with the view config dependencies, the patch at #28 does at least allow the update to proceed.

shouldn't the vocabulary be in the view dependencies and if so shouldn't that either prevent the vocabulary being deleted (or delete the view, although I don't think it should)? As it is we're letting the view get into an invalid state and suppressing the error.

#31: As @catch already stated in #29, this ^^ needs to be addressed before going on.

I tried to reproduce this issue, but could not (Checked in 10.1.6 and 11 versions)
Steps followed:

• Created a custom module and added config for vocabulary 'Custm Tags' in my_module/config/install.

# File name taxonomy.vocabulary.custom_tags.yml
langcode: en
status: true
name: Custom Tags
vid: custom_tags
description: 'Use tags to group articles on similar topics into categories.'
weight: 0
dependencies:
  enforced:
    module:
      - my_module

• Installed the module. 'Custom Tags' vocabulary got created in admin/structure/taxonomy
• Added few terme to the vocabulary.
• Created a view for the vocabulary

• Uninstalled the module.

Results:

• 'Custom Tags' got detered from admin/structure/taxonomy
• The view created for 'Custom Tags' also got deleted.

The issue summary needs to be updated with the proper steps to reproduce if this issue still exists.

Hi team, this ticket came up as the #bugsmash daily triage thread.

I'm just flagging that if we don't get an update on this within the next three months, it may be closed.

Cheers.