[2.x] Password reset page shows username rather than email when email_registration is enabled

Definitly makes sense!

@Grevil: Could you check the status in 2.x tomorrow (shortly) perhaps and post it here? (without the submodule)

@Anybody this shouldn't be a problem any more, since this username is only temporary. I'll check it.

Well, it still shows the username on password reset, but I guess this is fine?
E.g., if we create a user with the email "admin@test.de", we'll get a reset mail along the line of:

admin,

A request to reset the password for your account has been made at Drush
Site-Install.

(or admin_1, admin_2, ..., if "admin" was already taken).

I agree, that using the mail address of the user might be better.

(For everyone still having usernames prefixed with "email_registration_" or other usernames which should be overwritten, there is a new "Update username (from email_registration)" batch action to use.

Thank you, @JeremySkinner! Code snippet works and looks great! I just did some tiny adjustments to it! RTBC!

Adding a few security checks.

Alright, now there are enough changes to let somebody review this. Please review!

@Grevil I think the approach from ✨ Move obfuscation logic of submodule into main module Active might be better. Until we have that in place I'll postpone this.
If that isn't enough we should keep the code here to add this later. Back to NR then, if that should be the case.

@Grevil: You wrote:

It still shows the username on password reset.

What's the displayed username?

In the issue summary it was "email_registration_fxb78KrJHe"

if it's now "admin" for example for admin@example.com I think this could be seen as works as expected in 2.x and we could close this.
If it shows sth. like "email_registration_fxb78KrJHe" we should merge the MR.

I'm a bit unsure if the fix could introduce security risks, so if we don't need it, we shouldn't do it, I think!
Also, long-term ✨ Move obfuscation logic of submodule into main module Active might be the better and more general approach.

@Anybody, the original prefixed username ("email_registration_") doesn't show up on the password reset any more. As discussed locally, the username will still show up in several places and having this exception ONLY on the password reset page, is kind of odd, as it doesn't change anywhere else.

For the use case to have the email-address shown instead of the username in every place, you can use the newly added submodule, which syncs your mail address with your username!

Original issue is fixed.

Automatically closed - issue fixed for 2 weeks with no activity.