We've also run into this issue, which is causing our CI to fail. We've rolled back to 2.0.1 for now. Any chance of getting a new release with a fix for this as it breaks on all versions of Drupal 10.
Patch from #4 no longer applies with Core 10.3. I've attached a re-roll.
Many thanks for merging my fix!
Closing as I hadn't realised you'd already merged my fix! Thanks
JeremySkinner → created an issue.
hi @itamair yes you're correct - it looks like that has now been solved in core, thanks for pointing me in the right direction.
Added a short term fix to the issue fork.
JeremySkinner → created an issue.
I can also confirm the patch in #16 fixes the issue. Please can this patch be merged.
I also ran into this issue with 2.0-rc3 today and can confirm that the latest commit in dev works well for me
I'm very happy to create a follow up issue if needed, but the fix that's already been merged is not equivalent with the original behaviour. The fix I proposed in #15 is equivalent to the original correct behavior and would be much better if this could go into a stable release.
I'd like to re-open this issue if possible as the fix in #8 causes some other issues.
Rather than checking isAuthenticated I'd recommend going back to checking isAnonymous but also check isNew as well. The problem with isAuthenticated is that other modules may have switched out the logic here.
For example, the decoupled_auth module allows the concept of users without logins (eg for CRM systems where a user record may exist for CRM purposes, but not have a login attached to it), to do this it switches out the logic of isAuthenticated.
The change in #8 means that the decoupled_auth module no longer works with profile.
By using a combination of isAnonymous() and isNew(), you'd preserve the original behaviour without breaking modules that swap out the logic of isAuthenticated.
I've created an issue fork to propose the changes, I'd appreciate if you'd consider it. Many thanks.
JeremySkinner → made their first commit to this issue’s fork.
Thanks @itamair, we'll work towards upgrading to 10.x so we can make use of this.
hi @itamair I was going to review this on @andrewbelcher's behalf but we're unable to apply this patch to the 2.2.12 version of leaflet which we're using - it looks like the patch only supports 10.x.
I've attached a 2.2.x compatible version of the same patch. I've tested this against our application and it appears to be working correctly.