Sqlite's Connection::createConnectionOptionsFromUrl purposelessly converts relative paths to full

I didn't see this when I opened dupe 🐛 Can no longer create a SQLite database at a relative path Active

Retargeted to 11.x and rerolled.

Seems to have some test failures.

The status of the random test failures is, alas, rather unfortunate. Cannot remember not having to kick back test runs manually in the last month or so in any MR, especially if not MySql. Anyway, after playing some whacamole it's green on MySql and Sqlite now.

No longer a Starshot blocker since we've ditched WASM for now.

This one was approaching the 2 month mark of the review queue so going to give it a shot.

I rebased it since it was 200+ commits back (still applied cleanly though)
Issue summary seems clear and complete
Ran the test-only feature here https://git.drupalcode.org/issue/drupal-3056698/-/jobs/3821264 which still shows coverage
Test failure was random from rebase (re-ran and it's green)
Code wise change seems pretty straight forward.

believe this one is good to go.

Trying for a commit message

This behaviour with absolute paths in SQLite was added in #2232861: Create BrowserTestBase for web-testing on top of Mink → - given that we have good test coverage as we run all tests on SQLite I think this is good to go.

Committed and pushed 868e8468421 to 11.x and 87dd3ddf2fb to 11.1.x. Thanks!

We could file a follow-up to deprecate passing $root to \Drupal\Core\Database\Connection::createConnectionOptionsFromUrl - it is not used any implementations.

mondrake → closed merge request !1388

Filed 📌 Deprecate passing $root to \Drupal\Core\Database\Connection::createConnectionOptionsFromUr Active .