- πΊπΈUnited States bwong
I have not put a diff file together to fix this but I did figure out what is going on. Essentially the system automatically switches to a NumericField. This needs to be prevented. The trick is to keep track of the aggregation within the module and prevent the system from overriding and using the NumericField. It is then up to this module to provide that selection and to implement the selected aggregation function when generating the query.
- Assigned to bwong
- Status changed to Needs review
over 1 year ago 4:54am 25 April 2023 - πΊπΈUnited States bwong
This is almost a complete rewrite of the 8.x version. It works with Drupal versions 8 through 10. It includes support for fields, filters, sorts, and arguments. It adds token replacement and works with aggregation. A full version is include in case you don't want to contend with the patch. If the patch is acceptable I recommend that it be marked as version 1.0.
- First commit to issue fork.
- π©πͺGermany Anybody Porta Westfalica
@bwong the patch looks nice and I just wanted to create a MR on it, but it seems messed up. Looks like it was created based on the module in a subfolder.
Could you create the MR please or fix the patch? Would be nice to merge!
- Status changed to Needs work
3 months ago 11:35am 5 September 2024 - π©πͺGermany Anybody Porta Westfalica
I was finally able to apply the patch by recreating the folder structure used.
- Assigned to Anybody
- Issue was unassigned.
- π©πͺGermany Anybody Porta Westfalica
Okay the MR based on the patches is ready and fixes several issues plus aggregation compatibility.
Changing the
%argument%
placeholder to[argument]
is a breaking change, so this will need a new major release and at least an update hook to inform the users. - π©πͺGermany Anybody Porta Westfalica
@Grevil can you please implement the informing update hook by time, just to let people know
%argument%
placeholder changed to[argument]
token and people may need to update their views, if they used it?The module is alpha so it doesn't need automatical resolution and we'll merge this into a new branch 2.x (BC ok)
Afterwards we should merge this, as it fixes many bugs.
- Assigned to Grevil
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 7:58am 9 September 2024 - π©πͺGermany Grevil
Done:
Furthermore, I did some minor adjustments. LGTM! Please have a final look @anybody.
- Status changed to RTBC
3 months ago 8:01am 9 September 2024 -
anybody β
committed 292b61ae on 2.x
Issue #3051961 by anybody, grevil: Improve aggregation handling and fix...
-
anybody β
committed 292b61ae on 2.x
- Status changed to Fixed
3 months ago 8:01am 9 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.