Rerolling #15 to 8.x-1.0-alpha3. Updated service usages given the new
geocoderProviderStorage
instance variable. Removed the unused instance variablegeocoderConfig
and its associated service argument.While making #21 I noticed
Geocode::getParsedInput()
had its logic changed for when it throws theInvalidArgumentException
. I'm changing it back to how it is in the dev branch because it also matches how every other LocationInputPluginBase implements the logic: throw the exception if$input['value']
(or lat and lng) are empty. See Map.php and Raw.php.I reverted two tests to continue testing for that logic. I added one more test to match the ones #15 had added. I'm basing these tests off of the ones in RawTest.php.
- Status changed to Needs work
5 months ago 9:48am 15 September 2024 - πΊπΈUnited States SocialNicheGuru
No longer applies to drupal/search_api_location (dev-1.x 4a13f71)
Applying patches for drupal/search_api_location
https://www.drupal.org/files/issues/2023-02-22/3048597-22.patch β (Geocode LocationInput: Compatibility with Geocoder 3)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-02-22/3048597-22.patch β Removed the unrelated test class setUp method changes as it's out of scope here, though all test classes do need that public -> protected change.
- π§πͺBelgium BramDriesen Belgium π§πͺ
Can confirm the patch in #26 fixes the issue for us (and applies cleanly).