Account created on 28 June 2016, over 8 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΉAustria vierlex

I have reviewed the MR and can see that an additional a css class 'visually-hidden' will be set for when #description_display is invisible.
The tests are covering the description and the invisibility feature successfully.

I also noticed the data attribute 'data-drupal-field-elements' is being added, which doesn't seem to do anything?
Searching through the gitlab repository on the 11.x branch, there is only one more occurrence https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them...
Maybe this data attribute can be safely removed? Or does this improve accessibility somehow?

πŸ‡¦πŸ‡ΉAustria vierlex

Hello.

We are using the Module and rely on having it Output a JSON String to stdout.

The same problem has been creeping up in another Logging Project as well:
https://www.drupal.org/project/monolog/issues/3223751#comment-14385101 β†’

There are drush Issues:
https://github.com/drush-ops/drush/issues/4281
https://github.com/drush-ops/drush/issues/4790

But in the end, the way of logging JSON to stdout collides with a Symfony package which drush/drupal uses indirectly,
which uses stdout to pass around a JSON string, for 'communication purposes', when managing batch processes.
https://github.com/consolidation/site-process/issues/56

Since there is not easy way to change modules or the formatting of the log message in the project i am working on right now,
I opened up an MR which skips in that specific case any logging, which isn't ideal, but it makes the drush configuration import not crash anymore.

πŸ‡¦πŸ‡ΉAustria vierlex

vierlex β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024