- 🇳🇱Netherlands Lendude Amsterdam
In certain parts of Views this already gets type hinted as a ResultRow, see \Drupal\views\Entity\Render\EntityTranslationRendererBase::renderByRelationship which gets called from \Drupal\views\Plugin\views\row\EntityRow::render so being more strict here sounds good.
No idea if the deprecation message is the way we want to move towards stricter typing? Makes sense to me, but not sure if there are other examples of this already in core.
Also, if we use the deprecation message here we should add a type in D11 to the parameter, is a deprecation like this enough to get that done or do we need a follow up for that? The message should include a link to a change notice always right? - First commit to issue fork.
- Merge request !11781Resolve #3041170 "Rowpluginbaserender update docblock" → (Open) created by richgerdes
- 🇺🇸United States richgerdes New Jersey, USA
I tested this locally. Everything works as expected.
Converted the patch into a merge request and updated the depreciation message since we're no longer adding changes to 10.x branches.
- 🇺🇸United States richgerdes New Jersey, USA
I also created a second followup branch which includes an additional commit to set the type hint. I don't think there is a branch for merging into Drupal 12 yet, so not sure what the next steps would be. I would expect that it would need to be broken out into its own issue and postponed until D12 is in development probably.
- 🇺🇸United States smustgrave
Pipeline appears to have issues but the goal is to now do a deprecation summary + title need to reflect that.