Contrib.social

Throbber in off-canvas sidebar not visible

Open on Drupal.org →
Created on 13 March 2019, over 5 years ago
Updated 1 May 2024, 7 months ago

Problem/Motivation

When we have a throbber in an off-canvas sidebar it's background is set to a dark color, replacing the throbber gif. (fe. when using the moderation_sidebar → )
This was introduced in #2826722: Add a 'fence' around settings tray with aggressive CSS reset. → .

The CSS selector (in core/misc/dialog/off-canvas.base.css) does not what it should imo:

#drupal-off-canvas *,
#drupal-off-canvas *:not(div) {
  background: #444;
  font-family: "Lucida Grande", 'Lucida Sans Unicode', 'liberation sans', sans-serif;
  color: #ddd;
}

Proposed resolution

A simple change to the CSS selector does not overwrite it anymore.
So it would look like this:

#drupal-off-canvas *:not(div) {
  background: #444;
  font-family: "Lucida Grande", 'Lucida Sans Unicode', 'liberation sans', sans-serif;
  color: #ddd;
}

Maybe :before and :after need to be applied again ..

Remaining tasks

I'm not sure if anything relies on this.

User interface changes

None.

API changes

None.

🐛 Bug report
Status

Closed: outdated

Version

9.5

Component
Settings tray  →

Last updated 8 days ago

  • Maintained by
  • 🇺🇸United States @tedbow
Created by

🇨🇭Switzerland ytsurk Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇮🇳India Shubham Sharma 77

    Applied patch #20 applied successfully in drupal-9.5.x-dev
    Thanks for the patch
    For ref sharing screenshots...

  • Status changed to Postponed: needs info over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    per #23 would be nice to have steps to reproduce this. As it may require a test case.

  • Status changed to Closed: outdated 7 months ago
  • Comment 7 months ago →
    🇦🇺Australia pameeela

    This is already fixed in 10+, so this issue only applied to 9.x which is no longer supported. So I'm closing this.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024