- Status changed to Needs work
about 1 year ago 7:36pm 21 January 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- Assigned to lavanyatalwar
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The 8.x-1.x branch is no longer supported; any change needs to be done in the 2.x branch.
- Merge request !3Issue #3034265: Fix the errors/warnings reported by PHP_CodeSniffer โ (Open) created by apaderno
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
avpaderno โ changed the visibility of the branch 3034265-fix-the-errorswarnings to hidden.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The changes are just for using the short syntax for array and adding a
@var
line for a property declaration.IMO, they are so small that they should be fixed when fixing other issues in the code, if those issues are present. Otherwise, the merge request in this issue can be merged, at project maintainers' discretion.
- ๐ฎ๐ณIndia lavanyatalwar
The changes looks good to me
Moving it to RTBC.