500 error: Possible infinite loop

I was able to reproduce this with simplytest.me:

1. launch sandbox and login
2. create basic page
3. edit and save the page twice without any changes
4. go to node/1/revisions/view/2/3/visual_inline

Patch #2 seems to fix it, thank you!

#2 fixed it for us, thanks!

Thanks for the work on this one. I've recently taken up maintainership of this project and am looking through the RTBC issues.

I can't reproduce this issue following the steps in #5

To get this in, I'll need the patch on an MR against the latest 8.x-1.x code with tests added if possible.

Thanks!

silvi.addweb → made their first commit to this issue’s fork.

Hello, I have raised MR for the same.

Stumbled over this as well, what happened in our case is that a user used the language switcher while on the diff page, but those revisions had nothing useful in the other language and are more recent than any existing revisions in that language, so it basically looped into infinity and wrote about 1GB of database logs.

Raising priority because this has the possibility to take down a site if a user is confused and tries that a few times. There's also an old I think duplicate issue that was closed incorrectly ( #2939631: Infinite loop found in PluginRevisionController → ) and the somewhat related 🐛 TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count() Needs review

I created a new MR with a test for 2.x. As this says, this doesn't produce an error, it's while loop into infinity, so it will hit the max execution time limit at some point, if that's actually set at all.

The result is also a bit weird, the navigation links aren't actually useful, it might be more correct to not show them. but this is certainly better than the current behavior.

heddn → closed merge request !60

This has tests and multiple folks have manually tested this. LGTM.