- 🇮🇹Italy kopeboy Milan
To make this more flexible, I would add that this condition is a problem as well (at least for me):
The tax type will be used if both the customer and the store belong to one of the territories.
It would help to make the store part optional.
Please integrate Patch #10 into Commerce Core. This should be a basic requirement.
- Status changed to Needs review
over 1 year ago 3:25pm 22 September 2023 - last update
over 1 year ago 785 pass, 2 fail - Status changed to RTBC
11 months ago 11:34am 21 January 2024 - 🇳🇱Netherlands spokje
Patch has been working on a clients production environment without issues for a few months now, code changes look clean => RTBC.
- Status changed to Needs review
11 months ago 7:39am 22 January 2024 - last update
11 months ago 783 pass, 2 fail - 🇮🇱Israel jsacksick
I was more in favor of an explicit "All" option, but I think this approach also works... Tests are failing so attaching a new patch.
- 🇳🇱Netherlands spokje
Thanks @jsacksick.
I was more in favor of an explicit "All" option, but I think this approach also works...
If it would help getting this in faster and/or make you more happy, I'm happy to alter the current patch into an explicit "ALL" one.
I feel that *cough* "We, the people" *cough* want the functionality and don't "really" care too much about how the back-end enabling mechanism looks.
-
jsacksick →
committed ba05e24e on 8.x-2.x
Issue #3024929 by dieuwe, jsacksick, Fernly: Allow custom tax types to...
-
jsacksick →
committed ba05e24e on 8.x-2.x
-
jsacksick →
committed dd25a407 on 3.0.x
Issue #3024929 by dieuwe, jsacksick, Fernly: Allow custom tax types to...
-
jsacksick →
committed dd25a407 on 3.0.x
- Status changed to Fixed
11 months ago 7:55am 22 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.