- last update
over 1 year ago Patch Failed to Apply Patch #46 Tested on Drupal 9.5.x-dev. Patch applied successfully.
For the Drupal 10 test case is failing. Need to fix the test cases.
Before Patch:
After Patch:
- First commit to issue fork.
- Status changed to Needs review
3 months ago 6:31am 4 September 2024 - 🇫🇮Finland sokru
Updated the issue summary and rebased the MR to 11.x branch. I agree with #45 that doing more complete UX renew should be done on separate issue so we could fix this 6 years old issue first.
- Status changed to Needs work
3 months ago 4:18pm 4 September 2024 - 🇺🇸United States smustgrave
1 test I think we should consider is what if someone wnats to compare current revision with a revision on a 2nd page, will that still be possible.
- Status changed to Needs review
3 months ago 5:26am 5 September 2024 - 🇫🇮Finland sokru
we should consider is what if someone wnats to compare current revision with a revision on a 2nd page, will that still be possible.
Quoting @berdir from #43 🐛 Node revisions tab have "Current Version" on every Page Needs work
drupal core doesn't allow you to actually compare versions, that's diff.module which mostly replaces the current core functionality, as there's not really another way. With core, you can just manually compare by viewing the different revisions in separate tabs, that could be done across multiple pages.
I assume we don't want to include Diff module into core on this issue, so setting back to Needs review. Diff module uses routeSubscriber so changes in this MR does not have effect on Diff module.
- Status changed to Needs work
2 months ago 2:14pm 10 September 2024 - Status changed to Needs review
2 months ago 3:23pm 10 September 2024 - Status changed to RTBC
2 months ago 6:08pm 11 September 2024 - 🇳🇿New Zealand quietone
In #43 a UX review was asked for and I don't see that. Tagging for a review.
At least one thing that will be needed here is up to date screenshot available form the Issue summary. That same would be true for testing results. If they are in the issue summary, then the reviewer can find the correct work to review.