Node revisions tab have "Current Version" on every Page

Hi All,

Is it working for Drupal 10?

Thanks!

Patch #46 Tested on Drupal 9.5.x-dev. Patch applied successfully.
For the Drupal 10 test case is failing. Need to fix the test cases.
Before Patch:

After Patch:

Re-roll of #46 against Drupal 10.2.x.

Re-roll of #46 against Drupal 10.2.x.

Updated the issue summary and rebased the MR to 11.x branch. I agree with #45 that doing more complete UX renew should be done on separate issue so we could fix this 6 years old issue first.

sokru → changed the visibility of the branch 3021671-node-revisions-tab to hidden.

1 test I think we should consider is what if someone wnats to compare current revision with a revision on a 2nd page, will that still be possible.

we should consider is what if someone wnats to compare current revision with a revision on a 2nd page, will that still be possible.

Quoting @berdir from #43 🐛 Node revisions tab have "Current Version" on every Page Needs work

drupal core doesn't allow you to actually compare versions, that's diff.module which mostly replaces the current core functionality, as there's not really another way. With core, you can just manually compare by viewing the different revisions in separate tabs, that could be done across multiple pages.

I assume we don't want to include Diff module into core on this issue, so setting back to Needs review. Diff module uses routeSubscriber so changes in this MR does not have effect on Diff module.

Feedback has been addressed.

All feedback appears to be addressed.

In #43 a UX review was asked for and I don't see that. Tagging for a review.

At least one thing that will be needed here is up to date screenshot available form the Issue summary. That same would be true for testing results. If they are in the issue summary, then the reviewer can find the correct work to review.

Is this worth spending time on given this will swap to the generic revision UI in 📌 Switch Node revision UI to generic UI Needs review ?

I also noticed other weird behaviour when testing this such as the "Current revision" on the second page shows the revision log message of a different revision.