Text format with system name "php_code" is deleted when you view admin/modules/uninstall

Also see https://www.drupal.org/project/php/issues/2982416#comment-14963141 🐛 Opening "admin/modules/uninstall" removes input filter Closed: duplicate

The MR is correct.

As a side note, the code in PhpUninstallValidator is also wrong because it does not check which module is uninstalled (the $module parameter for validate()), with the effect of removing the input format configuration every time a module is uninstalled.
That code is also useless, as Drupal will never use an input filter it does not find because the module that implemented it has been uninstalled.

FilterUninstallValidator is documented as "Prevents uninstallation of modules providing used filter plugins", so it is meant to prevent the uninstallation, not to act on removing it.

Looking at the code removed, the $module is being checked if its 'php'. Why would it execute its logic in other cases?

Ah #44 cites https://api.drupal.org/api/drupal/core%21modules%21filter%21src%21Filter... which does check the usage of the format already globally.

The code attempts to remove the filter format when the module is uninstalled, but that is already handled with the dependency system in config, this part of the filter config in particular.

dependencies:
  module:
    - php

So all in all, yeah we should be entirely safe to remove this code.

Gábor Hojtsy → closed merge request !2

Automatically closed - issue fixed for 2 weeks with no activity.