- 🇮🇳India Indra patil Bangalore
Indra patil → made their first commit to this issue’s fork.
- @indra-patil opened merge request.
- Assigned to Indra patil
- 🇮🇳India Indra patil Bangalore
Created MR. and review the patch and its got failed I push my fixes to MR.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:53pm 20 February 2023 - 🇮🇳India Nayana Ramakrishnan
Verified MR!11 on Drupal version 9.5.x and OneLogin Integration version 8.x-2.x. The patch did not apply and its showing error:
Checking patch onelogin_integration.install... error: while searching for: <?php use Drupal\user\RoleInterface; /** error: patch failed: onelogin_integration.install:1 error: onelogin_integration.install: patch does not apply Checking patch onelogin_integration.module... Checking patch src/Controller/OneLoginIntegrationController.php... Hunk #1 succeeded at 137 (offset 23 lines). Checking patch src/Form/OneLoginIntegrationAdminForm.php... error: while searching for: $form['onelogin_integration'] = [ '#type' => 'fieldset', '#title' => t('OneLogin Integration - SSO Settings'), ]; $form['onelogin_integration']['info'] = [ '#markup' => t('Configure your SAML Service Provider below. Once configured, you can access the metadata <a target="_blank" href="@metadata">here</a>.<br>Further information for OneLogin customers can be found <a target="_blank" href="https://onelogin.zendesk.com/hc/en-us/articles/201173604-Configuring-SAML-for-Drupal">here</a>.', ['@metadata' => Url::fromRoute('onelogin_integration.metadata')->toString()]), ]; // The Identity Provider settings. $form['onelogin_integration_idp'] = [ '#type' => 'fieldset', '#title' => t('Identity Provider settings'), ]; $form['onelogin_integration_idp']['info'] = [ '#markup' => t('<p>Add information regarding your IdP.</p>'), ]; $form['onelogin_integration_idp']['entityid'] = [ '#type' => 'textfield', '#title' => t('Identity Provider (IdP) Entity Id'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('entityid'), '#description' => t('Identifier of the IdP entity. ("Issuer URL")'), '#required' => TRUE, ]; $form['onelogin_integration_idp']['sso'] = [ '#type' => 'textfield', '#title' => t('Single Sign On Service Url'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('sso'), '#description' => t('URL target of the IdP where the SP will send the Authentication Request. If your IdP has multiple URL targets, the one that uses the HTTP Redirect Binding should be used here. ("SAML 2.0 Endpoint (HTTP)")'), '#required' => TRUE, ]; $form['onelogin_integration_idp']['slo_option'] = [ '#type' => 'checkbox', '#title' => t('<strong>Single Log Out</strong>'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('slo_option'), '#description' => t('Enable SAML Single Log Out. SLO is complex functionality. The most common SLO implementation is based on front-channel (redirections). Sometimes if the SLO workflow fails, a user can be blocked in an unhandled view. Unless you have a strong grasp of SLO it is recommended that you leave it disabled. If enabled, enter the IdP"s SLO target URL below.'), '#required' => FALSE, ]; $form['onelogin_integration_idp']['slo'] = [ '#type' => 'textfield', '#title' => t('Single Log Out Service Url'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('slo'), '#description' => t('URL target for the IdP where the SP will send the SLO Request. ("SLO Endpoint (HTTP)")'), '#required' => FALSE, ]; $form['onelogin_integration_idp']['logout_link'] = [ '#type' => 'textfield', '#title' => t('Logout Redirect'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('logout_link'), '#description' => t('If Single Log Out is not used, you can choose to redirect a SAML user after they are logged out of Drupal. Some use this to redirect to an IdP logout page, a Central Authentication Service (CAS) logout page, or a custom page warning the user to close their browser to end their SSO session. This only affects users who have logged in via SAML.'), '#required' => FALSE, ]; $form['onelogin_integration_idp']['x509cert'] = [ '#type' => 'textarea', '#title' => t('X.509 Certificate'), '#default_value' => $this->configFactory->get('onelogin_integration.settings')->get('x509cert'), '#description' => t('Public x509 certificate of the IdP. The full certificate (including -----BEGIN CERTIFICATE----- and -----END CERTIFICATE-----) is required. ("X.509 certificate")'), '#required' => TRUE, ]; / error: patch failed: src/Form/OneLoginIntegrationAdminForm.php:49 error: src/Form/OneLoginIntegrationAdminForm.php: patch does not apply - Status changed to Needs review
over 1 year ago 5:53am 23 March 2023 - Assigned to sahil.goyal
- 🇮🇳India sahil.goyal
#8 applies cleanly, There are still error and warning left after applying patch
FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/onelogin_integration.install ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] Missing file doc comment 10 | ERROR | [ ] Unnecessarily gendered language in a comment 64 | ERROR | [ ] The array declaration extends to column 336 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/onelogin_integration.info.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/README.md ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 26 WARNINGS AFFECTING 27 LINES ----------------------------------------------------------------------------------------------------- 31 | WARNING | [ ] Line exceeds 80 characters; contains 185 characters 35 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters 39 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters 44 | WARNING | [ ] Line exceeds 80 characters; contains 153 characters 45 | WARNING | [ ] Line exceeds 80 characters; contains 150 characters 51 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters 53 | WARNING | [ ] Line exceeds 80 characters; contains 133 characters 54 | WARNING | [ ] Line exceeds 80 characters; contains 468 characters 60 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 61 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters 62 | WARNING | [ ] Line exceeds 80 characters; contains 505 characters 63 | WARNING | [ ] Line exceeds 80 characters; contains 241 characters 67 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters 68 | WARNING | [ ] Line exceeds 80 characters; contains 235 characters 69 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters 70 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters 71 | WARNING | [ ] Line exceeds 80 characters; contains 342 characters 72 | WARNING | [ ] Line exceeds 80 characters; contains 227 characters 109 | WARNING | [ ] Line exceeds 80 characters; contains 193 characters 113 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 117 | WARNING | [ ] Line exceeds 80 characters; contains 184 characters 121 | WARNING | [ ] Line exceeds 80 characters; contains 195 characters 133 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters 140 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters 146 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters 152 | WARNING | [ ] Line exceeds 80 characters; contains 144 characters 161 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/onelogin_integration.module --------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 21 ERRORS AND 2 WARNINGS AFFECTING 19 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 22 | ERROR | [x] Expected 1 space before "-"; 0 found 22 | ERROR | [x] Expected 1 space after "-"; 0 found 65 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_login_form_alter" but expected | | "onelogin_integration_user_login_form_alter" 76 | WARNING | [x] A comma should follow the last multiline array item. Found: TRUE 105 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 109 | ERROR | [x] Data types in @param tags need to be fully namespaced 112 | ERROR | [ ] Type hint "array" missing for $form 126 | ERROR | [x] Expected "int" but found "integer" for parameter type 128 | ERROR | [x] Expected 1 space after asterisk; 2 found 128 | ERROR | [x] Expected "bool" but found "boolean" for function return type 128 | ERROR | [ ] Description for the @return value is missing 130 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_use_onelogin" but expected | | "onelogin_integration_user_use_onelogin" 139 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 147 | ERROR | [x] Data types in @param tags need to be fully namespaced 150 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_remove_onelogin" but expected | | "onelogin_integration_user_remove_onelogin" 167 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 171 | ERROR | [x] Data types in @param tags need to be fully namespaced 174 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_drupal_form_alter" but expected | | "onelogin_integration_user_drupal_form_alter" 175 | ERROR | [x] Expected 1 space before "-"; 0 found 175 | ERROR | [x] Expected 1 space after "-"; 0 found 187 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 188 | WARNING | [x] A comma should follow the last multiline array item. Found: 7 --------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/src/AuthenticationService.php ------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement 32 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/101x/drupal/modules/contrib/onelogin_integration/src/Controller/OneLoginIntegrationController.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 1 WARNING AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 157 | WARNING | [x] 'TODO: efficienter maken.' should match the format '@todo Fix problem X here.' 194 | ERROR | [ ] Variable "RelayState" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed 197 | ERROR | [ ] Variable "SAMLResponse" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed 198 | ERROR | [ ] Variable "RelayState" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed 199 | ERROR | [ ] Variable "RelayState" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed 218 | ERROR | [ ] Variable "SAMLResponse" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed 218 | ERROR | [ ] Variable "SAMLResponse" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- Time: 248ms; Memory: 12MBworking on it
- Issue was unassigned.