Create occurrences for latest and default versions

Created on 30 October 2018, about 6 years ago
Updated 22 August 2023, over 1 year ago

Create occurrences for both latest and default revision.

Using concepts made popular by Content Moderation, allows site builder to join on occurrences of latest or default.

If content is not revisionable, only latest.

✨ Feature request
Status

Needs work

Version

3.4

Component

Views

Created by

πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

    Will need coverage for both the core generation functionality and views integration to ensure new and existing views are not adversely affected.

  • πŸ‡ΊπŸ‡¦Ukraine ruslan piskarov Kyiv, Ukraine

    With applied https://www.drupal.org/project/date_recur/issues/3205682 ✨ Add primary key to occurrence tables Needs work I see a fatal error like SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '0-0-31919529' for key 'PRIMARY': INSERT INTO "date_recur__node__field_recurring_dates" ("entity_id", "field_delta", "delta", "field_recurring_dates_value", "field_recurring_dates_end_value", "revision_id") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => 31919529 [:db_insert_placeholder_1] => 0 [:db_insert_placeholder_2] => 0 [:db_insert_placeholder_3] => 2023-10-12T16:10:00 [:db_insert_placeholder_4] => 2023-10-12T17:00:00 [:db_insert_placeholder_5] => 32311192

  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia
  • First commit to issue fork.
  • πŸ‡³πŸ‡±Netherlands ekes
  • Pipeline finished with Failed
    8 months ago
    Total: 170s
    #172573
  • πŸ‡³πŸ‡±Netherlands ekes

    ekes β†’ changed the visibility of the branch 3010184-create-occurrences-for to hidden.

  • πŸ‡³πŸ‡±Netherlands ekes

    Added Kernel tests to describe the functionality of the patch in https://git.drupalcode.org/issue/date_recur-3010184/-/compare/3.5.x...3.... The branch does not (yet) look at the views integration. I'll be honest I'm still a bit confused that it indexes the default version, and the latest version; and then only the default and latest. I guess this is where looking at the views integration comes in.

    Additional explanatory note https://git.drupalcode.org/issue/date_recur-3010184/-/compare/3.5.x...3.... The existing tests passed with field values of cardinality 2, but storage of 1, because they were working on the inserted entity. But on loading (the default revision) from storage, of course, the second value was not loaded as it was not stored. Basically presently should you save an entity with a date recur field with more values than its cardinality it does calculate occurrences for the invalid deltas.

  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

    Marking as a maintainer-approved issue.

    This does not signify the code/discussion to date are ready.

Production build 0.71.5 2024