- last update
over 1 year ago Composer require-dev failure - π©πͺGermany Anybody Porta Westfalica
It's unbelievable. This critical issue exists since > 2 years and the maintainers just don't care? I think they must have missed this issue. Going to contact them via PM.
@Nixou could you please provide the patch as MR to make it easier to review and merge for the maintainers?
Thanks! :)
Related issue : π Page freeze caused by Symfony 6 non-scalar error when tokensNotFound is triggered Needs review . There is a patch which solved this problem.
- π©πͺGermany Anybody Porta Westfalica
Thanks @omar_emailat - still this are separate issues. The frontend should never wait for the response, but run async, was written above.
- Status changed to Needs work
3 months ago 6:39am 19 September 2024 - π©πͺGermany Anybody Porta Westfalica
Next step should be to prepare a MR from the latest patch. This is still horrible to use, waiting for the UI.
For that reason, I'd suggest adding a note to the description of the new setting:
+ $form['auto_refresh']['auto_refresh_seo_result'] = [ + '#type' => 'checkbox', + '#title' => $this->t('Enable auto refresh of the Real Time SEO widget result'), + '#description' => $this->t('You can use this setting to allow or deny auto refreshing of the Real Time SEO widget results after a value of a form field is changed and a field focus is lost.'), + '#default_value' => $config->get('auto_refresh_seo_result'), + ];
like
Please note that this may cause UI delays, waiting for e.g. the Metatag values to become available to calculate the score
(A native speaker should improve the sentence).
- π©πͺGermany Grevil
LGTM! Tested it and everything seems to be working as expected!
Added 2 more comments otherwise RTBC.
- π©πͺGermany Anybody Porta Westfalica
Perfectly fine now @lrwebks! RTBC from my side, thank you!!