Language tour tips constantly appending string.

Created on 12 October 2018, about 6 years ago
Updated 31 January 2023, almost 2 years ago

When attempting to use Language, Tour Module, and the Tour UI module there is an issue when saving or modifying the language-overview or the language-continue tips will constantly append text to the body regardless if the tips have the provided text that are being appended.

Steps to Reproduce in UI

* Download and Install Tour_UI module
* Enable Language module
* Add Language Module

Go to Tour UI config then edit the language tour. Edit the any tour tip like Adding languages and press save. Then edit the Languages tip and there should be a repeating text. It may take 1-2 times of reproducing the previous before it is noticeable.

The way to programmatically do it is to load the tips and loop through them to see the constant output:

$tour = \Drupal::entityTypeManager()->getStorage('tour')->load('language');
$tips = $tour->getTips();
foreach ($tips AS &$tip){
echo($tip->id());
echo($tip->get('body'));
}

$tips = $tour->getTips();
foreach ($tips AS &$tip){
echo ($tip->id());
echo ($tip->get('body'));
}

The biggest culprit is the language_tour_tips_alter function

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
Language moduleΒ  β†’

Last updated 23 days ago

  • Maintained by
  • πŸ‡©πŸ‡ͺGermany @sun
Created by

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    So just FYI tour is being considered for removal from core and moved to contrib (where hopefully we will fold in Tour UI) so not sure if adding a fix to core for something being removed will work.

    But this would need tests also.

Production build 0.71.5 2024