Sacramento, CA
Account created on 7 June 2012, over 12 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

This is working now thanks for the merge!

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I was able to confirm this works for me and fixes the issue we were having.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I was able to confirm the following works as intended.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA
πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Thank you! I was able to confirm this is working as requested!

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Thank you! I was able to confirm this is there and is working and satisfying needs.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Following up. Is there anything else I need to do for this?

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Thank you for the examples. I went ahead and modeled my constructor comments after those.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Hi @nkarhoff,

After further review it looks like there is an issue with the Gin theme and how it is handling ajax requests but I was able to address some of the other issues that came up as part of this.

Thanks!

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Thank you for your help and your review. I have made the necessary changes and fixes.

I will say that I was a bit confused on the constructor messaging so if you could take a look and let me know if what I did was correct or not. If not, if you have an example you could show that would be amazing.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Created a Merge Request with a proposed fixed.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I realized that it wasn't super clear on how to test this.

  1. Download Module
  2. Install domain and domain_alias modules.
  3. Must have Drush 11+ installed.
  4. Add Domain either through UI or using Drush command (drush help domain:add for more info)
  5. Test all the following commands:
    • List out Domain Aliases: drush domain-alias:list
    • Add Domain Alias: drush domain-alias:add
    • Update Domain Alias: drush domain-alias:update
    • Delete a Single Domain Alias: drush domain-alias:delete
    • Bulk Delete Aliases for a domain: drush domain-alias:delete-bulk
πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I added a drush command that allowed for the following:

drush domain-alias:list
drush domain-alias:add
drush domain-alias:update

drush domain-alias:delete
drush domain-alias:delete-bulk

With the following, it should give basic CRUD the ability to manage domain aliases via Drush so that domain aliases can be created to use with systems like Tugboat or mostly any other dynamic staging environment where the URL isn't static.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

Changing status and able to confirm this works and allows me to use with Drupal 10

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I was able to test this and confirmed that I'm no longer seeing the issues any longer

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I have read the following and have confirmed that Drupal Standards are being applied to the code.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

sean_e_dietrich β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States sean_e_dietrich Sacramento, CA

I didn't work on the tests but for the time being, rerolled the patch to work with the latest version of 7.x-2.x and should work on 7.x-2.14

Production build 0.71.5 2024