🇺🇸United States @sean_e_dietrich

Following up. Is there anything else I need to do for this?

sean_e_dietrich → made their first commit to this issue’s fork.

Thank you for the examples. I went ahead and modeled my constructor comments after those.

Hi @nkarhoff,

After further review it looks like there is an issue with the Gin theme and how it is handling ajax requests but I was able to address some of the other issues that came up as part of this.

Thanks!

Thank you for your help and your review. I have made the necessary changes and fixes.

I will say that I was a bit confused on the constructor messaging so if you could take a look and let me know if what I did was correct or not. If not, if you have an example you could show that would be amazing.

Created a Merge Request with a proposed fixed.

sean_e_dietrich → created an issue.

Tested patch and am no longer getting the error.

I realized that it wasn't super clear on how to test this.

1. Download Module
2. Install domain and domain_alias modules.
3. Must have Drush 11+ installed.
4. Add Domain either through UI or using Drush command (drush help domain:add for more info)
5. Test all the following commands:
   
   • List out Domain Aliases: drush domain-alias:list
   • Add Domain Alias: drush domain-alias:add
   • Update Domain Alias: drush domain-alias:update
   • Delete a Single Domain Alias: drush domain-alias:delete
   • Bulk Delete Aliases for a domain: drush domain-alias:delete-bulk

I added a drush command that allowed for the following:

drush domain-alias:list
drush domain-alias:add
drush domain-alias:update

drush domain-alias:delete
drush domain-alias:delete-bulk

With the following, it should give basic CRUD the ability to manage domain aliases via Drush so that domain aliases can be created to use with systems like Tugboat or mostly any other dynamic staging environment where the URL isn't static.

sean_e_dietrich → created an issue.

Changing status and able to confirm this works and allows me to use with Drupal 10

I was able to test this and confirmed that I'm no longer seeing the issues any longer

I have read the following and have confirmed that Drupal Standards are being applied to the code.

sean_e_dietrich → created an issue.

mel-miller → credited sean_e_dietrich → .

mel-miller → credited sean_e_dietrich → .

mel-miller → credited sean_e_dietrich → .

mel-miller → credited sean_e_dietrich → .

mel-miller → credited sean_e_dietrich → .

sean_e_dietrich → made their first commit to this issue’s fork.

thejimbirch → credited sean_e_dietrich → .

thejimbirch → credited sean_e_dietrich → .

I didn't work on the tests but for the time being, rerolled the patch to work with the latest version of 7.x-2.x and should work on 7.x-2.14