- 🇺🇸United States smustgrave
let me ask is there a chance something other then the types we think could of been sent? If so then won't we need a trigger_error?
Tagging for a change record.
Now the argument type hints in the method definition for the createInstance singleton method and the constructor are not the same:
public static function createInstance($definition, $name = NULL, TraversableTypedDataInterface $parent = NULL)
vs
public function __construct(DataDefinitionInterface $definition, $name = NULL, TypedDataInterface $parent = NULL)
These should be the same, so the createInstance should have the DataDefinitionInterface type hint for the first argument and the constructor should have the TraversableTypedDataInterface type hint for the third argument.
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
let me ask is there a chance something other then the types we think could of been sent? If so then won't we need a trigger_error?
Tagging for a change record.