a11y: Input type file fields lack aria-describedby to the description

Tagging with WCAG SC 3.3.2: Labels or Instructions

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The patch is working for simple input type file with Drupal 10.1.6 for me. It doesn't work however when using webform and multiple pages.

Luke.Leber → made their first commit to this issue’s fork.

Luke.Leber → changed the visibility of the branch 2998857-additional-information-needed to hidden.

This change needs tests. It would also be great to test Webform to ensure that the elements that extend managed file are also swept up and fixed.

Approach-wise, I feel that this logic belongs in \Drupal\file\Element\ManagedFile::processManagedFile class versus the FormBuilder because the file module provides the managed_file element plugin.

Fingers crossed, test bot.

Additionally manually confirmed attribute coverage against a "real world" site (via Webform).

• Audio files
• Document files
• Generic files (this is the core render element!)
• Image files
• Video files

Cheers

Ran test-only feature

1) Drupal\Tests\file\Functional\FileManagedFileElementTest::testManagedFile
Behat\Mink\Exception\ElementNotFoundException: Element matching css "[aria-describedby="edit-file--description"]" not found.
/builds/issue/drupal-2998857/vendor/behat/mink/src/WebAssert.php:465
/builds/issue/drupal-2998857/core/modules/file/tests/src/Functional/FileManagedFileElementTest.php:49
FAILURES!
Tests: 5, Assertions: 66, Failures: 1.

To confirm coverage

Verified this with the Media file fields and confirm they are now getting aria-describedby.

I've just commented on the corresponding thread on the #accessibility channel only. but would it make sense to open up a follow up issue to add the aria-describedby to the image field as well? cuz there the ui and micro copy is basically the same as the file field but for the image field the description still isnt announced.

@rkoller - yes let's open a follow-up to fix image fields too.

Committed and pushed 74b6cedac2 to 11.x and 3960a5d417 to 11.0.x and 5b240ef43d to 10.4.x and 07c0011de5 to 10.3.x. Thanks!

Nice find!

xjm → closed merge request !8523

xjm → closed merge request !1650

xjm → changed the visibility of the branch 11.x to hidden.

xjm → changed the visibility of the branch 11.x to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.