- First commit to issue fork.
- 🇺🇸United States alison
I rebased the merge request so it's mergeable 🎉 Or so I think! -- I'm still newish to merge request rebasing in the context of Drupal issue forks, hopefully I did it correctly 🤞
-------
BUT! I see the test failure, so it seems there's still work to do. - 🇨🇦Canada er.pushpinderrana Vancouver
#84 patch introduced #3214648: Error in layout builder: Argument #1 ($title) must be of type string, null given → issue for me.
- Status changed to Needs review
6 months ago 4:26am 7 May 2024 - last update
6 months ago 2 fail The last submitted patch, 88: Breadcrumb-markup-double-eascaped-2990464-88.patch, failed testing. View results →
- 🇮🇳India ravi kant Jaipur
ravi kant → made their first commit to this issue’s fork.
- last update
6 months ago 1 fail - 🇩🇪Germany spuky
@Jelle_S thanks for your effort would it be possible to have that as an MR ?
- Merge request !128issue: #2990464 patch 93 + changes required to match dev → (Open) created by spuky
- Status changed to Needs review
3 months ago 1:04pm 7 August 2024 - 🇩🇪Germany spuky
Did move the patch +93 into an new mr
And adapted the Test "testGetTitleString" to assert for Drupal\Core\Render\Markup instead of String.
Would be nice to get that in after this long time... Would love to have at least a few RTBCs before merging.
- 🇩🇪Germany spuky
@jonasane...
What is wrong with the MR that you rerroll 93 ? Why not download the plain diff of the MR use it as local patch... and give feedback on that...
- 🇩🇪Germany spuky
For everybody still using a patch workflow here is the MR as a patch so we get feedback on whats actually to be merged...
- 🇺🇸United States robpowell Boston
I've tested on 10.2 and it works well, I no longer see `&`.
Note for those trying to apply the patch, confirm you are on the latest tag. The patch would not apply on 2.0.6.
- 🇩🇪Germany spuky
Putting back to needs review... since not applying to 2.0.6 when we are on 2.0.8 is not something that needs work ;-)