Contrib.social

Removed unused class property $translationFilesDirectory

Open on Drupal.org →
Created on 2 August 2018, almost 7 years ago
Updated 15 March 2023, about 2 years ago

Problem/Motivation

The property $translationFilesDirectory is defined in two test files and set in
\Drupal\Core\Test\FunctionalTestSetupTrait::prepareEnvironment but it is not used.

\Drupal\TestSite\Commands\TestSiteInstallCommand::$translationFilesDirectory
\Drupal\Tests\BrowserTestBase::$translationFilesDirectory

FunctionalTestSetupTrait::prepareEnvironment() sets $this->translationFilesDirectory. However it's being set to $this->siteDirectory . '/translations' where it should be $this->siteDirectory . '/files/translations'. Also it's not declared in FunctionalTestSetupTrait but instead in BrowserTestBase and TestBase.

This currently does not surface, as it's not being used anywhere.

Proposed resolution

Either remove the member variable completely or fix it and use it in various install tests. Alternatively it could also be moved to InstallerTestBase.

Remaining tasks

Research the history of the property to determine what to do.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

9.5

Component
Other  →

Last updated about 12 hours ago

Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024