getResults is not returning the correct results

Created on 1 August 2018, almost 6 years ago

Updated 22 October 2023, 8 months ago

I try Voting Api Widget and the module is not getting a correct result from the methods "getResults" in class "VotingApiWidgetBase" and "BaseRatingForm". votingapiResult in Voting Api module seems to have changed, and now return results based in vote type (in this case $entity->bundle()), I think that previously it worked well that way since nobody had reported this issue and certainly think it's an improvement in Voting Api module but I think we should modify these methods.

I have made a patch that seems to work and fix the issue, this is attached.
Regards
Juan

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇻🇪Venezuela jvizcarrondo

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update 8 months ago
Waiting for branch to pass
Comment 8 months ago →
🇺🇦Ukraine artem_sylchuk Lutsk
Attempted to re-roll the patch as it doesn't apply to the dev version anymore
Comment 8 months ago →
🇺🇸United States TR Cascadia
This still absolutely needs a test case to demonstrate the error and prove the fix.
Comment 8 months ago →
System Message
The last submitted patch, 24: votingapi_widgets-getresults-2990032-24.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Comment 8 months ago →
🇺🇸United States TR Cascadia

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024