- πΊπΈUnited States loze Los Angeles
Its been some time since the original issue and patches.
Since then this module now uses the users display name instead of the username, which resolves 1/2 of what was being addressed in the original patches.
I have created MR!121 which adds realname support to the autocomplete query for the members widget if realname is installed.
here is a patch for the MR to use with composer.
- πΊπΈUnited States loze Los Angeles
Last patch in #22 was wrong, some unintended changes made it in there.
this one should work with composer - π·π΄Romania claudiu.cristea Arad π·π΄
Isn't this reduced to the idea of using User::getDisplayName()?
- πΊπΈUnited States loze Los Angeles
@claudiu.cristea I dont believe that getDisplayName() is a queryable field, right?
I'm trying to get the auto complete search to use the compiled display name that is stored in the realname table.
- π·π΄Romania claudiu.cristea Arad π·π΄
Thank you. I think you're right. I'm not a very big fan of adding module soft dependencies (aka "if module exists..."). Is there any way you can hook in from a 3rd-party and alter the suggestions? At least maybe we can create a submodule to add realname support. I admit I didn't have time to give a deeper look at this
- Status changed to Closed: works as designed
about 2 months ago 5:36am 21 January 2025 - πΊπΈUnited States loze Los Angeles
Thanks. Since the original post, this module now has its own entity reference selection plugin instead of using a direct query. So I created an issue in realname to support private_message which is just a small change and it appears to be working with the 3.0 branch.
β¨ Private Message module support Active
- π·π΄Romania claudiu.cristea Arad π·π΄
I think now, with 4.x, it still can be fixed here.
- π·π΄Romania claudiu.cristea Arad π·π΄
@loze, could you please try MR!175 but without the Real Name patch?
- πΊπΈUnited States loze Los Angeles
Yes, MR!175 does appear to do the job with version 4.0 alpha
thanks!
- π·π΄Romania claudiu.cristea Arad π·π΄
Thank you, @lotze
I have fixed also the schema alteration for
default:user
plugin settings just in case. I will merge this MR as soon as you test again the latest version MR against 4.0.0-alpha1 and confirm that works as expected by setting this issue status to RTBC - πΊπΈUnited States loze Los Angeles
Tested with alpha2 and dev and it seems to do the trick. Thanks!
-
claudiu.cristea β
committed 044e5de6 on 4.x
Issue #2987189 by loze, claudiu.cristea, nishruu, adam clarey, cosolom,...
-
claudiu.cristea β
committed 044e5de6 on 4.x
Automatically closed - issue fixed for 2 weeks with no activity.