- Merge request !2Issue #2974195: Replace README.txt with README.md and update README.md file → (Open) created by Akshay kashyap
- Status changed to Needs review
over 1 year ago 7:34am 7 June 2023 - Status changed to RTBC
over 1 year ago 5:06pm 8 June 2023 - 🇮🇳India kavitha@specbee.com
The patch works fine and moving it to RTBC.
- Status changed to Needs work
over 1 year ago 6:13pm 13 July 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:43pm 17 July 2023 - Status changed to Needs work
over 1 year ago 2:34pm 17 July 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:46am 18 July 2023 - Status changed to Needs work
over 1 year ago 8:02am 18 July 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:41am 18 July 2023 - Status changed to Needs work
over 1 year ago 8:48am 18 July 2023 - Status changed to Needs review
over 1 year ago 12:27pm 30 August 2023 - Status changed to RTBC
about 1 year ago 11:48am 21 October 2023 - 🇧🇪Belgium Frederikvho Belgium
Hi,
I reviewed all the merge request commands and re-reviewed the README.md file. It looks fine now.
Moving to RTBC. - Status changed to Needs work
about 1 year ago 1:33pm 21 October 2023 - Status changed to Needs review
about 1 year ago 2:18pm 21 October 2023 - 🇧🇪Belgium Frederikvho Belgium
Hi @apaderno,
Thanks for that catch and good to know.
I fixed it in the latest commit to the MR. - Status changed to Needs work
about 1 year ago 4:34am 6 November 2023 - 🇵ðŸ‡Philippines kenyoOwen
Hi Frederikvho
I reviewed your MR!2 and the "Requirements" section is not following the README.md template, no spacing after
This module requires the following modules:
it should beThis module requires the following modules: - [Facets](https://www.drupal.org/project/facets)
as per the README.md template.
Thank you
- 🇧🇪Belgium Frederikvho Belgium
Hi kenyoOwen,
Thanks. This was unclear for me as the documentation had both variations with and without a white line there. I have just pushed a white line in the latest commit.
I also updated the documentation for this, as others may face the same confusion and overhead.
https://www.drupal.org/node/2181737/revisions/view/13282134/13298418 → - 🇧🇪Belgium Frederikvho Belgium
Hi apaderno,
I fixed the 57 characters line.
Also changed the documentation because it had both a whitespace and no whitespace for the specific part that kenyoOwen highlighted.
I hope this is okay.Thanks
- Assigned to nitin_lama
- Status changed to Needs review
about 1 year ago 11:29am 6 December 2023 - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 8:57am 7 December 2023 - Assigned to nitin_lama
- Status changed to Needs review
about 1 year ago 9:12am 7 December 2023 - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 3:09am 18 December 2023 - 🇵ðŸ‡Philippines kenyoOwen
Hi nitin_lama
I reviewed your changes in MR!2 and fixed comment #35 issues and it follows the READMEmd template, but I noticed a missing dot in the project page
For a full description of the module, visit the [project page](http://drupal.org/project/active_facet_pills)
Thank you
- Assigned to nitin_lama
- Status changed to Needs review
about 1 year ago 5:05am 20 December 2023 - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 1:56am 22 December 2023 - 🇵ðŸ‡Philippines kenyoOwen
Hi nitin_lama
I reviewed your changes and resolved the feedback in comments #35 and #9. It also follows the README.md template.
Thank you.