- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
For the tests requested in #4
Also should follow the default template for an issue summary please.
- Merge request !3442Issue #2961541: ExtensionDiscovery fails to scan the vfsStream filesystem for modules or profiles β (Open) created by joachim
- π¬π§United Kingdom joachim
Rebase on 10.1.x and made a MR.
Still needs test.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Maybe deleting the work-around in
\Drupal\Tests\ckeditor5\Kernel\CKEditor5PluginManagerTest
which was necessary before this fix is enough to prove it now works β maybe we don't really need explicit test coverage for such a detail? πUnless it fails, of course.
π± Which it does!
- last update
over 1 year ago 29,340 pass, 2 fail - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Looks like the static file cache in
\Drupal\Core\Extension\ExtensionDiscovery
is still a problem. There's no way to wipe that. - last update
over 1 year ago 29,340 pass, 2 fail - Assigned to wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Worked on this again for π Provide guidance to config schema developers: detect broken config schema types Needs work . I'm pretty sure I have a solution now. π€
- Issue was unassigned.
- Status changed to Needs review
11 months ago 1:16pm 6 February 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Hm, looks like the CKEditor 5 plugin manager test is extra complicated due to
\Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition::getTypedConfig()
using the (global) container, which contains some static caches that get in the way. π¬ - Status changed to Needs work
11 months ago 10:01am 11 February 2024 - π§πͺBelgium borisson_ Mechelen, π§πͺ
Back to needs work to correctly reflect the current state.
I see that you also implemented this fix (or at least the\Drupal::root
call) in π Provide guidance to config schema developers: detect broken config schema types Needs work , does that mean we close this as a duplicate or do we want to keep this open? - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
We should keep this open: this issue is specifically scoped to fix this problem, in #3401837 I had no choice but to figure out a solution for this. Ideally we'd be able to remove this change from #3401837 to allow a tighter scope π