FieldTypePluginManager::createInstance() produces warnings unless fed dummy options

public function create(DataDefinitionInterface $definition, $value = NULL, $name = NULL, $parent = NULL) { $typed_data = $this->createInstance($definition->getDataType(), [ 'data_definition' => $definition, 'name' => $name, 'parent' => $parent, ]);

$field_type_manager = \Drupal::service('plugin.manager.field.field_type'); $instance = $field_type_manager->createInstance($type, ['field_definition' => $state_field, 'name' => NULL, 'parent' => NULL]);

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
@jodavidson opened merge request.
Status changed to Needs review over 1 year ago2:51pm 8 June 2023
Comment over 1 year ago →
🇨🇦Canada jodavidson
Confirmed that TypedDataManager::createInstance() does not gracefully handle the missing name and parent parameters.

Added some code to set those elements of the array if not present.
Status changed to Needs work over 1 year ago3:27pm 8 June 2023
Comment over 1 year ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
Status changed to Needs review over 1 year ago3:15pm 12 June 2023
Comment over 1 year ago →
🇨🇦Canada jodavidson
Unfortunately my coded editor respected the Symfony standard rather than the Drupal one. Oops. Fixed and re-pushed.
Status changed to Needs work over 1 year ago1:36am 13 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Can the issue summary be updated to highlight the proposed solution.

Also as a bug will need a test case to show the issue.
Comment over 1 year ago →
🇬🇧United Kingdom joachim
> Can the issue summary be updated to highlight the proposed solution.

It's this:

> FieldTypePluginManager should take care of this.