Contrib.social

Invalid exposed form data not excluded

Open on Drupal.org →
Created on 30 March 2018, almost 7 years ago
Updated 18 May 2024, 8 months ago

Problem/Motivation

Unfortunately I've forgotten what lead me to fix this :D but the code is clearly nonsensical and this change fixed something. If I have time I'll revert it and test to see.

In the code ViewsExposedForm::submitForm()

  1. initialises $excludes[] on line 153,
  2. adds invalid exposed input keys to it,
  3. and then initialises it again on line 170, thereby deleting the added keys.

The fix is to remove the second $excludes = [...]; on line 170.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Views  →

Last updated about 3 hours ago

Created by

🇬🇧United Kingdom hughworm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment 8 months ago →
    🇺🇸United States diegopino

    This bug is still around (6 years!) in 11.x. but both patches are failing bc the tests are not passing once the actual "excluded" elements are no longer part of the raw data and thus removed from the URLs

    e.g here
    https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/views...

    and here at
    ExposedFormRenderTest::testExposedFormRawInput

    The Layout builder one might be just layout builder failing in 10.1 so all needs to be rebased to 11.x-dev
    @quietone since you are already in this, do you want to tackle that or you ok with me giving it a shot?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024