Invalid exposed form data not excluded

Created on 30 March 2018, about 7 years ago
Updated 22 January 2023, over 2 years ago

Problem/Motivation

Unfortunately I've forgotten what lead me to fix this :D but the code is clearly nonsensical and this change fixed something. If I have time I'll revert it and test to see.

In the code ViewsExposedForm::submitForm()

  1. initialises $excludes[] on line 153,
  2. adds invalid exposed input keys to it,
  3. and then initialises it again on line 170, thereby deleting the added keys.

The fix is to remove the second $excludes = [...]; on line 170.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
ViewsΒ  β†’

Last updated about 3 hours ago

Created by

πŸ‡¬πŸ‡§United Kingdom hughworm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024