Contrib.social

Fix the issues reported by Pareview.sh

Open on Drupal.org →
Created on 16 March 2018, about 7 years ago
Updated 14 March 2023, about 2 years ago

Problem/Motivation

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/file_download_tracker.services.yml
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/EventSubscriber/FileDownloadTrackerEventSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 4 WARNINGS AFFECTING 15 LINES
-------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
22 | ERROR | [x] Expected 1 blank line before function; 0 found
23 | ERROR | [x] Short array syntax must be used to define arrays
29 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
29 | ERROR | [ ] Missing parameter comment
29 | ERROR | [x] Data types in @param tags need to be fully namespaced
32 | ERROR | [ ] Variable "FileID" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed
38 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
39 | ERROR | [x] Expected 1 space after IF keyword; 0 found
43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
44 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
45 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
47 | ERROR | [ ] Variable "FileID" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed
64 | ERROR | [x] Expected 1 blank line after function; 0 found
65 | ERROR | [x] Expected 1 newline at end of file; 2 found
65 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/FileDownloadEntityListBuilder.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
32 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
37 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/Plugin/views/field/FdtEntityNameField.php
------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------
47 | WARNING | [ ] Possible useless method overriding detected
58 | ERROR | [x] Expected 1 space after IF keyword; 0 found
63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
67 | ERROR | [x] Expected 1 blank line after function; 0 found
68 | ERROR | [x] Expected 1 newline at end of file; 2 found
68 | ERROR | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/Entity/FileDownloadEntity.php
------------------------------------------------------------------------------------------------------
FOUND 185 ERRORS AND 2 WARNINGS AFFECTING 180 LINES
------------------------------------------------------------------------------------------------------
48 | ERROR | [x] Opening brace should be on the same line as the declaration
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Opening brace should be on the same line as the declaration
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
58 | ERROR | [x] Short array syntax must be used to define arrays
59 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Opening brace should be on the same line as the declaration
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
73 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
76 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
77 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
79 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Opening brace should be on the same line as the declaration
91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Opening brace should be on the same line as the declaration
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
107 | ERROR | [x] Opening brace should be on the same line as the declaration
108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
115 | ERROR | [x] Opening brace should be on the same line as the declaration
116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
124 | ERROR | [x] Opening brace should be on the same line as the declaration
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
132 | ERROR | [x] Opening brace should be on the same line as the declaration
133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
140 | ERROR | [x] Opening brace should be on the same line as the declaration
141 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
149 | ERROR | [x] Opening brace should be on the same line as the declaration
150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
154 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
158 | ERROR | [x] Opening brace should be on the same line as the declaration
159 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
159 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
162 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
166 | ERROR | [x] Opening brace should be on the same line as the declaration
167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
174 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
175 | ERROR | [x] Opening brace should be on the same line as the declaration
176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
182 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
183 | ERROR | [x] Opening brace should be on the same line as the declaration
184 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
192 | ERROR | [x] Opening brace should be on the same line as the declaration
193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
200 | ERROR | [x] Opening brace should be on the same line as the declaration
201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
202 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
209 | ERROR | [x] Opening brace should be on the same line as the declaration
210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
212 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
213 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
219 | ERROR | [x] Short array syntax must be used to define arrays
220 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
221 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
222 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
224 | ERROR | [x] Short array syntax must be used to define arrays
225 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
226 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
227 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
227 | ERROR | [x] Short array syntax must be used to define arrays
228 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
229 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
230 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
231 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
237 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
238 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
241 | ERROR | [x] Short array syntax must be used to define arrays
242 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
243 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
246 | ERROR | [x] Short array syntax must be used to define arrays
247 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
248 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
249 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
251 | ERROR | [x] Short array syntax must be used to define arrays
252 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
253 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
258 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
259 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
261 | ERROR | [x] Short array syntax must be used to define arrays
262 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
262 | ERROR | [x] Short array syntax must be used to define arrays
263 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
264 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
267 | ERROR | [x] Short array syntax must be used to define arrays
268 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
269 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
270 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
272 | ERROR | [x] Short array syntax must be used to define arrays
273 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
274 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
279 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
280 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
283 | ERROR | [x] Short array syntax must be used to define arrays
284 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
285 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
286 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
288 | ERROR | [x] Short array syntax must be used to define arrays
289 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
290 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
295 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
296 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
298 | ERROR | [x] Short array syntax must be used to define arrays
299 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
300 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
301 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
303 | ERROR | [x] Short array syntax must be used to define arrays
304 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
305 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
309 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
311 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
312 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
317 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
318 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
321 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
322 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
325 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
326 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
331 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
332 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
338 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
339 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
345 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
347 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
347 | ERROR | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 185 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/Entity/FileDownloadEntityInterface.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
17 | WARNING | There must be no blank line following an inline comment
71 | WARNING | Line exceeds 80 characters; contains 90 characters
---------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/Entity/FileDownloadEntityViewsData.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
19 | WARNING | [x] There must be no blank line following an inline comment
19 | WARNING | [ ] There must be no blank line following an inline comment
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/FileDownloadEntityTranslationHandler.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | [x] There must be no blank line following an inline comment
12 | WARNING | [ ] There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/FileDownloadEntityStorage.php
------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------
26 | ERROR | [x] Short array syntax must be used to define arrays
36 | ERROR | [x] Short array syntax must be used to define arrays
44 | ERROR | [x] Short array syntax must be used to define arrays
53 | ERROR | [x] Short array syntax must be used to define arrays
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/FileDownloadTracker.php
-----------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
13 | ERROR | Missing member variable doc comment
26 | ERROR | Public method name "FileDownloadTracker::getFileID" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/src/FileDownloadEntityStorageInterface.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
21 | WARNING | Line exceeds 80 characters; contains 90 characters
32 | WARNING | Line exceeds 80 characters; contains 84 characters
---------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/file_download_tracker.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 2 WARNINGS AFFECTING 18 LINES
------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
25 | ERROR | [x] Case breaking statements must be followed by a single blank line
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Short array syntax must be used to define arrays
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
50 | ERROR | [x] You must use "/**" style comments for a function comment
58 | ERROR | [x] Short array syntax must be used to define arrays
59 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
64 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
66 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/file_download_tracker.info.yml
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/README.txt
-------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------
19 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
40 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
60 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: /var/www/html/drupal9new/modules/contrib/file_download_tracker/file_download_tracker.views.inc
----------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
15 | ERROR | [x] Short array syntax must be used to define arrays
17 | ERROR | [x] Short array syntax must be used to define arrays
20 | ERROR | [x] Short array syntax must be used to define arrays
23 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

Time: 302ms; Memory: 12MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig "module_name"

Proposed resolution

Resolve the PHPCS issues.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India rajeshwari10

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇮🇳India Charchil Khandelwal

    The patch #7 has been reviewed and applied cleanly, but a few phpcs still remain.

    FILE: ...pal\modules\file_download_tracker\file_download_tracker.info.yml
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    1 | WARNING | "core_version_requirement" property is missing in the
    | | info.yml file
    ----------------------------------------------------------------------

    FILE: ...rupal\modules\file_download_tracker\file_download_tracker.module
    ----------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n"
    | | but found "\r\n"
    10 | WARNING | [x] Unused use statement
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    FILE: ...acker\src\EventSubscriber\FileDownloadTrackerEventSubscriber.php
    ----------------------------------------------------------------------
    FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n"
    | | but found "\r\n"
    14 | WARNING | [ ] The class short comment should describe what the
    | | class does and not simply repeat the class name
    38 | WARNING | [ ] \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    43 | WARNING | [ ] \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    45 | WARNING | [ ] \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    FILE: ...ules\file_download_tracker\src\FileDownloadEntityListBuilder.php
    ----------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n"
    | | but found "\r\n"
    32 | WARNING | [x] Inline @var declarations should use the /** */
    | | delimiters
    37 | ERROR | [x] Short array syntax must be used to define arrays
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    FILE: ...\modules\file_download_tracker\src\FileDownloadEntityStorage.php
    ----------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n" but
    | | found "\r\n"
    26 | ERROR | [x] Short array syntax must be used to define arrays
    36 | ERROR | [x] Short array syntax must be used to define arrays
    44 | ERROR | [x] Short array syntax must be used to define arrays
    53 | ERROR | [x] Short array syntax must be used to define arrays
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    FILE: ...drupal\modules\file_download_tracker\src\FileDownloadTracker.php
    ----------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n"
    | | but found "\r\n"
    11 | WARNING | [ ] The class short comment should describe what the
    | | class does and not simply repeat the class name
    13 | ERROR | [ ] Missing member variable doc comment
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    FILE: ...e_download_tracker\src\Plugin\views\field\FdtEntityNameField.php
    ----------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    ----------------------------------------------------------------------
    1 | ERROR | [x] End of line character is invalid; expected "\n"
    | | but found "\r\n"
    47 | WARNING | [ ] Possible useless method overriding detected
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

  • Comment about 2 years ago →
    🇮🇳India Charchil Khandelwal
  • @charchil-khandelwal opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review about 2 years ago
  • Comment about 2 years ago →
    🇮🇳India Charchil Khandelwal

    Created MR for this, please review.

  • Assigned to Kamlesh Kishor Jha
  • Comment about 2 years ago →
    🇮🇳India Kamlesh Kishor Jha Jaipur

    I will review this MR.

  • Issue was unassigned.
  • Status changed to RTBC about 2 years ago
  • Comment about 2 years ago →
    🇮🇳India Kamlesh Kishor Jha Jaipur

    MR !3 looks good to me.
    So moving it to RTBC.

    Thanks.

  • Status changed to Needs work about 2 years ago
  • Comment about 2 years ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

  • Comment about 2 years ago →
    🇮🇳India indrapatil Bangalore
  • Status changed to Needs review about 2 years ago
  • Comment about 2 years ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024