- 🇩🇪Germany mrshowerman Munich
In case anyone needs it, here's #149 re-rolled to 9.5.x. The only change is the updated imports mentioned by @MegaChriz.
- Status changed to Needs work
almost 2 years ago 11:19am 7 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
almost 2 years ago 11:22am 7 February 2023 - 🇫🇷France nod_ Lille
Bot was tripped up by the last patch for a different branch than the issue's.
- 🇳🇱Netherlands megachriz
Let's hide the patch that's not relevant for the commit.
- 🇫🇷France nod_ Lille
Excluding this issue from bot review since
1. The last patch is for a different branch and no tests were run on it (as such I'm not able to know it's for a different branch and to ignore it)
2. There is an open MR more recent than the actual patch that needs to be committed. - Status changed to Fixed
almost 2 years ago 9:58am 19 February 2023 - 🇫🇮Finland lauriii Finland
Few notes:
- Was surprised to see that File didn't have a list builder and why are we adding it here. This is explained in #143.
- The install profile changes seem fine. I like that the default config is built based on what makes sense rather than just applying the post update. Re-installed with Standard and Umami to make sure the defaults make sense and #145 has been addressed.
- Confirmed that sorting the table is sufficient for ensuring deterministic tests. Looks like there aren't any files with random names meaning this is fine.
- Dropbuttons with a single option in Claro look a bit strange but eventually this will be addressed by ✨ Add new Splitbutton render element to eventually replace Dropbutton Needs work .
-
+++ b/core/modules/file/file.post_update.php @@ -13,3 +16,17 @@ function file_removed_post_updates() { + /** @var \Drupal\views\ViewsConfigUpdater $view_config_updater */
Removed this comment on commit.
Committed 0d58b3c and pushed to 10.1.x. Thanks!
Not backporting to 10.0.x or 9.5.x because of the post update hook.