Fix the errors/warnings reported by PHP_CodeSniffer

try to fixing some coding standard

Hi the patch #101 applied cleanly. However there are still many issues reported by phpcs. Working on and providing updated patch.

Thanks!

@arpitk
I think that the first step is to review the three remaining merge requests that are open. Or if you want to write a patch, only make changes that are not covered by the MR's. When I've time to review this issue again, I'll first handle off the open merge requests.

Hello, after updating to the latest version of this module (beta4), which includes this MR originated from this issue I began to have this error:

ArgumentCountError: Too few arguments to function Drupal\feeds\Feeds\Target\File::__construct(), 9 passed in web/modules/contrib/feeds/src/Plugin/Type/Target/MediaTargetBase.php on line 49 and exactly 11 expected in Drupal\feeds\Feeds\Target\File->__construct() (line 101 of modules/contrib/feeds/src/Feeds/Target/File.php).

Therefore I created a patch specifically for this, if you guys can review it, I really appreciate it.

@isa.bel
Thanks for the patch, but I think it would be better to update this in ✨ Add a mapping target to media field Needs review , as the code you are changing is not yet part of Feeds.
Looking at ✨ Add a mapping target to media field Needs review , it looks like your changes are already applied to the latest patch that is provided there. So I think all you need is to update to a newer patch from that issue.

Hi @MegaChriz, thank you for your reply, we were already using that patch, but from comment #56 so it was outdated, I already updated it and applied it, and now the code is already in place. Thanks again!

MegaChriz → changed the visibility of the branch 2939688-Syndication+Tests to hidden.

MegaChriz → changed the visibility of the branch 2939688-File+Tests to hidden.

MegaChriz → changed the visibility of the branch 2939688-UserRole+Tests to hidden.

MegaChriz → changed the visibility of the branch 2939688-Feeds to hidden.

MegaChriz → changed the visibility of the branch 2939688-Others to hidden.

MegaChriz → changed the visibility of the branch 2939688-Tests to hidden.

MegaChriz → changed the visibility of the branch 2939688-coding-standard-issue to hidden.

MegaChriz → changed the visibility of the branch 2939688-fix-coding-standards to hidden.

The remaining phpcs issues have been fixed!

Since this issue started, we now also have eslint, phpstan and styleint issues to fix, but let's do that in a follow-up.

Two follow-ups have been opened:

🐛 Fix PHPStan errors Needs work
🐛 Fix eslint and styleint issues Active

Automatically closed - issue fixed for 2 weeks with no activity.