Method to use the refresh token

Dylan Donkersgoed → made their first commit to this issue’s fork.

wulff → changed the visibility of the branch 2923419-method-to-use to hidden.

Hi, is this going to be merged soon

I tested this and it works for me +1

Fixing tag

Re-rolled the MR for v3 and made sure refreshTokens() stays closer to how retrieveTokens() behaves.

I attached a patch that used json_decode() rather than Json::decode(), fixed that.

Looks like this is now incorporated into 💬 Store and Use Refresh Token on Expiry Active so assuming that gets in, let's give credit to the folks here too. For now, I think we should direct our efforts over there.

Let's have a maintainer decide that please? This issue predates the one you linked to, is far smaller in size and has been reviewed already. Generally, as a maintainer, I like smaller narrow-scoped MRs as they're easier to review and commit.

If this gets committed first it shouldn't even affect the MR in the other issue as the diff will simply get smaller.

In that case, the RTBC was really for the non-v3 MR, not your patch, which needs review.

However, I just reviewed your code and it looks good. Also, we tested it as part of testing the other issue so RTBC actually does make sense now so leaving status as-is.