- Assigned to joaopauloc.dev
- Merge request !4791Adding default value validation on NumberWidget → (Closed) created by joaopauloc.dev
- last update
almost 2 years ago Custom Commands Failed - last update
almost 2 years ago 30,165 pass, 2 fail - last update
almost 2 years ago Custom Commands Failed - last update
almost 2 years ago 30,158 pass - last update
almost 2 years ago 30,154 pass, 2 fail - last update
almost 2 years ago 30,158 pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 8:03pm 15 September 2023 - Status changed to Needs work
almost 2 years ago 2:30pm 18 September 2023 - 🇺🇸United States smustgrave
I applied the MR and followed the steps in the issue summary
Created a Number(Integer)
Added 10 to the minimum
Added 6 as the defaultI can save still.
- last update
almost 2 years ago 30,166 pass, 2 fail - last update
almost 2 years ago 30,204 pass - Status changed to Needs review
almost 2 years ago 8:16pm 22 September 2023 - 🇧🇷Brazil joaopauloc.dev
Thanks for the review @smustgrave, issues are fixed.
- Status changed to RTBC
almost 2 years ago 1:46pm 25 September 2023 - 🇺🇸United States smustgrave
Confirmed the issue I was seeing in #21 has been fixed.
- last update
almost 2 years ago 30,209 pass - last update
almost 2 years ago 30,361 pass - last update
almost 2 years ago 30,361 pass - last update
almost 2 years ago 30,361 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - last update
almost 2 years ago 30,378 pass - last update
almost 2 years ago 30,381 pass, 2 fail - last update
almost 2 years ago 30,383 pass, 2 fail - last update
almost 2 years ago 30,392 pass, 2 fail - last update
almost 2 years ago 30,396 pass, 2 fail 39:52 36:03 Running- last update
almost 2 years ago 30,414 pass, 2 fail - last update
almost 2 years ago 30,419 pass, 2 fail - last update
almost 2 years ago 30,425 pass, 2 fail - last update
almost 2 years ago 30,433 pass, 2 fail - last update
almost 2 years ago 30,437 pass, 2 fail - Status changed to Needs work
almost 2 years ago 12:05pm 27 October 2023 - 🇫🇮Finland lauriii Finland
Looks like the new test failed after the rebase 😔
- 🇮🇳India Akhil Babu Chengannur
\Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase::getConstraints calls Drupal\Core\Field\FieldItemBase::getSettings and Drupal\Core\Field\Plugin\Field\FieldWidget\NumberWidget::formElement calls Drupal\Core\Field\WidgetBase::getFieldSettings to check for min and max values while saving the number field. But both getSettings and getFieldSettings return NULL for min and max values when field settings are saved for the first time. This is why validation is not working.
- 🇮🇳India Akhil Babu Chengannur
Re tested in drupal 11 and \Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase::getConstraints works. Drupal\Core\Field\FieldItemBase::getSettings correctly returns min and max values when creating the field.
- Status changed to Needs review
almost 2 years ago 11:06am 5 December 2023 - 🇮🇳India Akhil Babu Chengannur
Review if error is reproducible in 11.x-dev
- Status changed to Needs work
almost 2 years ago 2:37pm 5 December 2023 - 🇺🇸United States smustgrave
Feedback from MR still needs to be addressed.
- Status changed to Closed: cannot reproduce
almost 2 years ago 1:32pm 13 December 2023 - 🇧🇷Brazil joaopauloc.dev
This issue was fixed on the current 11-x.
Follow the test below.
Not sure if I'm updating correctly but we don't need to fix the one anymore.
Thanks.