Field UI doesn't validate a field's default value on create

I applied the MR and followed the steps in the issue summary
Created a Number(Integer)
Added 10 to the minimum
Added 6 as the default

I can save still.

Thanks for the review @smustgrave, issues are fixed.

Confirmed the issue I was seeing in #21 has been fixed.

Looks like the new test failed after the rebase 😔

\Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase::getConstraints calls Drupal\Core\Field\FieldItemBase::getSettings and Drupal\Core\Field\Plugin\Field\FieldWidget\NumberWidget::formElement calls Drupal\Core\Field\WidgetBase::getFieldSettings to check for min and max values while saving the number field. But both getSettings and getFieldSettings return NULL for min and max values when field settings are saved for the first time. This is why validation is not working.

Re tested in drupal 11 and \Drupal\Core\Field\Plugin\Field\FieldType\NumericItemBase::getConstraints works. Drupal\Core\Field\FieldItemBase::getSettings correctly returns min and max values when creating the field.

Review if error is reproducible in 11.x-dev

Feedback from MR still needs to be addressed.

This issue was fixed on the current 11-x.
Follow the test below.

Not sure if I'm updating correctly but we don't need to fix the one anymore.
Thanks.

joaopauloc.dev → closed merge request !4791