Give Media a menu item under Content

Created on 4 September 2017, almost 7 years ago
Updated 5 February 2023, over 1 year ago

Problem/Motivation

Using Admin Toolbar β†’ , "Media" does not have its own menu item under "Content" in the toolbar. This causes additional mouse clicks to get to the "Media" page. This is also not consistent with how the "Comments" entity is being displayed.

Proposed resolution

Update the following files in the Media Module to include the menu item details:
media.links.action.yml
media.links.menu.yml
media.links.task.yml
media.routing.yml

Remaining tasks

The menu item has been added under content but now when you click "Content" the "Media" tab has been removed (it was on the right of "File").

User interface changes

"Media" will have its own menu item under "Content" in the Toolbar.

✨ Feature request
Status

Needs work

Version

10.1 ✨

Component
MediaΒ  β†’

Last updated 1 day ago

Created by

πŸ‡¦πŸ‡ΊAustralia campbellt_

Live updates comments and jobs are added and updated live.
  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    Was previously tagged for tests which still needs to happen.
    MR should be updated for 10.1 also.

  • πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

    i've read through the issue summary and the comments. please correct me if i am wrong but i wonder if the issue is still relevant? cuz when admin toolbar is installed the submenu items for the media menu item are in place aka added by admin_toolbar (drupal 10.1.x-dev & admin_toolbar 3.3.0):

    the media menu item was added to admin_toolbar in the following issue #3026216: Add media link to content menu in toolbar β†’ and a more dynamic generation is worked on in this issue currently: ✨ generalize creation of 'add ENTITY' and 'add BUNDLE' links Needs review . with or without admin_toolbar installed the tab for media is also in place at /admin/modules .
    the only detail if admin_toolbar is not installed and you go to /admin/structure/menu/manage/admin you only have content and comments as it's child menu item - files and media are missing. but the child menu item comments isn't reachable via the admin toolbar anyway where only the content top level menu item could be reached (without admin_toolbar installed). therefore i am not sure if this issue is still relevant?

  • πŸ‡¬πŸ‡§United Kingdom AaronMcHale Edinburgh, Scotland

    @rkoller Yes, this issue is still relevant, and likely will become required if the latest recommendations on #2862859: Create a top level, extendable, "Content" admin menu route that behaves like "Structure" β†’ are implemented.

    It is correct there is a local task for Media under Content, but there is not a menu item. A way to see this visually is to add the "Administration" menu as a block in a region of a site and you will see that in Core, there are no menu items under Content. Obviously, Admin Toolbar is working around this by injecting its own menu items, but if this issue was done it would also negate the need for Admin Toolbar to do that.

    It's also worth noting that with the wider moves to modernise the Core Toolbar, enhancements like this issue will become more important.

Production build 0.69.0 2024